Affected versions:
Firefox 83.0b3
Firefox 83.0a1

Affected platforms:
Windows 10

Steps to reproduce:

1. Launch Firefox
2. Enable high contrast
3. Focus the awesome bar
4. Type a search engine keyword or select any from the one-offs
5. Observe the search keyword close button

Expected result:
Close button should be visible in high contrast

Actual result:
Search keyword close x button is not visible in high contrast mode

Regression range
I will see for a regression if there is one asap

Suggested severity
S3-S4

Field is the background color of the urlbar, so using it as the fallback for
the indicator's close button background means that it will always be the same
color as the urlbar background. In Windows high-contrast mode, it will be black;
in light themes, it will be white, the current hardcoded value; and in dark
themes it will continue to be the LWT color due to the rule's use of var here.

I'll request uplift once this is on m-c.

https://hg.mozilla.org/mozilla-central/rev/4b2288d37d56

Here's the expected appearance with the bug fix.

Comment on attachment 9183587 [details]
Bug 1673011 - Make the search indicator close button background the same as the urlbar background, which fixes high-contrast mode.

Beta/Release Uplift Approval Request

• User impact if declined: People using high-contrast mode on Windows won't be able to see the close button in the search mode indicator.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please enable high-contrast mode on Windows and see comment 5 for the expected appearance.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a simple CSS-only change that should have no effect for people who aren't using Windows high-contrast mode.
• String changes made/needed:

Verified as fixed with Firefox 84.0a1 (2020-10-29) on Windows 10x84 and Windows 7x64.

Comment on attachment 9183587 [details]
Bug 1673011 - Make the search indicator close button background the same as the urlbar background, which fixes high-contrast mode.

Approved for 83 beta 6, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/5d001d485c3e

Verified on Firefox 83.0b6 with Windows 10x64 and Windows 7x64.