Remove nsLayoutUtils::MIN_ISIZE and nsLayoutUtils::PREF_ISIZE
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Both are name aliases to IntrinsicISizeType::MinISize and IntrinsicISizeType::PrefISize.
https://searchfox.org/mozilla-central/rev/86d73c5d10674d964de467e157402f160d1d2945/layout/base/nsLayoutUtils.h#1407-1408
IntrinsicISizeType::MinISize is 4-char longer than nsLayoutUtils::MIN_ISIZE. If people are feeling lazy to type, we could rename IntrinsicISizeType::MinISize to IntrinsicISizeType::Min.
|
Assignee | |
Comment 1•4 years ago
|
||
Both are aliases to IntrinsicISizeType::MinISize and
IntrinsicISizeType::PrefISize.
Remove MOZ_ASSERT in nsLayoutUtils::IntrinsicForAxis and
nsContainerFrame::DoInlineIntrinsicISize since IntrinsicISizeType is a
enum class nowadays, which cannot have other values.
I've compiled this patch with DEBUG_INTRINSIC_WIDTH defined in
nsLayoutUtils.cpp, and fixed aWM undefined in
nsLayoutUtils::MinSizeContributionForAxis().
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•