Closed Bug 1673492 Opened 4 years ago Closed 4 years ago

Downgrade the "two layers that scroll together have different ancestor transforms" assertion to an NS_ASSERTION

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: botond, Assigned: botond)

Details

(Whiteboard: [fuzzblocker])

Attachments

(1 file)

We have a MOZ_ASSERT in APZ code that gets hit when two scroll nodes ("layers" in pre-WebRender teminology) that scroll together have different ancestor transforms.

This situation usually arises in Web Painting code due to various edge cases. We have a number of reports about it (bug 1450686, bug 1491000, bug 1576514, bug 1587369, bug 1652619) that have gone unfixed, in some cases for 2+ years.

As we have not had reports of these situations causing actual rendering or scrolling problems, and the MOZ_ASSERT (which crashes debug builds) has been tripping up fuzzers, I propose downgrading this to an NS_ASSERTION.

botond: Thank you very much!

Whiteboard: [fuzzblocker]
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b6e00081bdb Downgrade the assertion about two layers that scroll together having different ancestor transforms, to an NS_ASSERTION. r=kats
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: