Closed
Bug 1673806
Opened 4 years ago
Closed 2 years ago
Refactor StyleSheetManager#update
Categories
(DevTools :: Style Editor, task)
DevTools
Style Editor
Tracking
(firefox102 fixed)
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: daisuke, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a follow-up of bug 1664941.
As Julian suggested, we'd better rename the function name to be distinction more. And also, make the optional parameters to be dictionary parameter.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•2 years ago
|
Summary: Refactor update() function in server-side stylesheet watcher. → Refactor StyleSheetManager#update
|
|
Assignee | |
Comment 1•2 years ago
|
||
The new name better conveys what the method does.
We take this as an opportunity to have an option
object as the third parameter, to old optional
arguments (transition, kind and cause).
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0b78fc4d21a
[devtools] Rename StyleSheetManager#update and change its signature. r=daisuke.
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•