Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news|
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.6)
Attachments
(2 files)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
When bug 1425962 and bug 1466705 were done no equivalent strings were added for SeaMonkey. This means wherever bug 1425962 and bug 1466705 have/get landed we would break.
[Approval Request Comment]
Regression caused by (bug #): 1425962
User impact if declined: Broken subscribe dialog when bug 1425962 is applied
Testing completed (on m-c, etc.): 2.53.x
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 removals, 2 additions
[Approval Request Comment]
Regression caused by (bug #): 1466705
User impact if declined: Broken subscribe dialog when bug 1466705 is applied
Testing completed (on m-c, etc.): 2.53.x
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 additions
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9184385 [details] [diff] [review]
Additions for bug 1425962
LGTM
|
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9184386 [details] [diff] [review]
Additions for bug 1466705
LGTM
|
|
||
Updated•4 years ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c8813a3ae2c8
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1425962 part. r=frg
https://hg.mozilla.org/comm-central/rev/cc1b4c09df39
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1466705 part. r=frg
|
|
||
Updated•4 years ago
|
|
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9184385 [details] [diff] [review]
Additions for bug 1425962
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/21dc88f2a172c1993bf5dc099d946e5631b6e25f
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1425962 part. r=frg a=frg
|
|
||
Comment 7•4 years ago
|
||
1673959
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9184386 [details] [diff] [review]
Additions for bug 1466705
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/13d1aa3c4aaf955473dd6a6b445d0d2cee16fa9e
Port extra strings from |Bug 1425962 - Subscribe dialog broken for IMAP and news| and |Bug 1466705 - Fix subscribe dialog for IMAP and news| - bug 1466705 part. r=frg a=frg
Description
•