Closed Bug 1674091 Opened 4 years ago Closed 4 years ago

Bookmarks toolbar height shrinks when empty, and is shown on new tab even when empty

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Version:
Firefox 84
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: me, Assigned: jaws)

References

(Regressed 1 open bug)

Details

Attachments

(3 files)

Bug 1674091 - Add a getter for the Bookmarks Toolbar in BookmarkingUI.
(deleted), text/x-phabricator-request
Details
Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar.
(deleted), text/x-phabricator-request
Details
Bug 1674091 - Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette.
(deleted), text/x-phabricator-request
Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

  1. Take an empty profile.
  2. Have browser.toolbars.bookmarks.visibility set to its recent new default of “newtab”.
  3. Go to a new tab.
  4. Delete the “Get Involved” bookmark that’s in the Bookmarks Toolbar, so that the Bookmarks Toolbar folder is empty.

Actual results:

The bookmarks toolbar remains, but starts taking up less vertical space.

Expected results:

The bookmarks toolbar should either retain its original height, or disappear.

I’m inclined to think that disappearing is better, at least in the case of newtab. If it’s always, I dunno. (As I’ve alluded to in bug 1674090, I feel that newtab makes this toolbar less a toolbar and more a part of about:newtab.)

Blocks: 1665353
Component: Untriaged → Bookmarks & History
Severity: -- → S4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2ed373e6fc3 Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs https://hg.mozilla.org/integration/autoland/rev/4d49ba20a908 Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers https://hg.mozilla.org/integration/autoland/rev/b37a366b6bca Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4db429711269 Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs https://hg.mozilla.org/integration/autoland/rev/437053f5228a Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs https://hg.mozilla.org/integration/autoland/rev/5c55402f9d41 Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers

https://hg.mozilla.org/mozilla-central/rev/4db429711269
https://hg.mozilla.org/mozilla-central/rev/437053f5228a
https://hg.mozilla.org/mozilla-central/rev/5c55402f9d41

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1677300
Flags: needinfo?(jaws)
Regressions: 1677425

The bug title contains "Bookmarks toolbar height shrinks when empty" and this is still true (at least on macOS, I can't test on other platforms). Is this expected?

Flags: needinfo?(jaws)
Regressions: 1678921
No longer depends on: 1680966

(In reply to Sören Hentzschel from comment #8)

The bug title contains "Bookmarks toolbar height shrinks when empty" and this is still true (at least on macOS, I can't test on other platforms). Is this expected?

We tried to limit this on Windows but should take a second look on macOS. Can you file a new bug as this one is now closed?

Flags: needinfo?(jaws) → needinfo?(soeren.hentzschel)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)

(In reply to Sören Hentzschel from comment #8)

The bug title contains "Bookmarks toolbar height shrinks when empty" and this is still true (at least on macOS, I can't test on other platforms). Is this expected?

We tried to limit this on Windows but should take a second look on macOS. Can you file a new bug as this one is now closed?

We already have a mac bug for this, as it was caught by our test infrastructure - bug 1678666.

Flags: needinfo?(soeren.hentzschel)
Regressions: 1684698
Regressions: 1694546
No longer regressions: 1694546
Regressions: 1712905
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: