Refactor XDR format decision code
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
Currently we use the UseOffThreadParseGlobal() flag to decide if we should use stencil or script format for XDR data. As we tune performance of stencil-mvp, it is helpful to have the option of changing the format independant of the parse-global status.
|
Assignee | |
Comment 1•4 years ago
|
||
No change to behaviour, but move the exception earlier instead of mutating
CompileOptions after they are saved.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Instead of relying directly on the UseOffThreadParseGlobal() flag to
determine the format of the XDR buffer, refactor to add useStencilXDR
locals to use. In the future, we can hook this to a different condition that
is independant of the parse-global status.
Also move the encoding of stencil until after instantiation for simplicity.
In the past, instantiation would mess with the stencil, but that has been
resolved now.
Depends on D95379
|
|
Assignee | |
Comment 3•4 years ago
|
||
No changes to behaviour. This splits the useOffThreadParseGlobal flag into
cases that care about the format and cases that care about the GC.
Depends on D95380
|
|
Assignee | |
Comment 4•4 years ago
|
||
Here is prototype that stacks on this bug to use stencil format for incremental-xdr even with parse-global enabled.
https://hg.mozilla.org/try/rev/f2e894d567dea67e2f46f9c7ae1262cfad7aa09a
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f0b90b1cbf4b
https://hg.mozilla.org/mozilla-central/rev/0c96eb1d965a
https://hg.mozilla.org/mozilla-central/rev/6f7804d504b1
Description
•