nsNavHistoryResult.cpp: do not use 'else' after 'return'
Categories
(Toolkit :: Places, task, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: ankushsinghal1995)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/toolkit/components/places/nsNavHistoryResult.cpp#3418-3437
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Removed the 'else' block after the return statement in the 'if' block
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
This is my first time contributing here. Please let me know if any other process needs to be followed.
Comment 3•4 years ago
|
||
You did it right, thank you. If you have further questions, feel free to ask.
Assignee | ||
Comment 5•4 years ago
|
||
Thanks for your review. Now that the commit has been pushed to the codebase, should I Resolve the bug?
Reporter | ||
Comment 6•4 years ago
|
||
It will be done automatically :)
autoland is a staging branch, the bug will be closed when the change is moved to the nightly branch (called mozilla-central)
Comment 7•4 years ago
|
||
Now the patch is on the integration branch, autoland (https://treeherder.mozilla.org/#/jobs?repo=autoland). About twice a day the integration branch is merged into the main branch, mozilla-central (https://treeherder.mozilla.org/jobs?repo=mozilla-central).
So, if this doesn't cause unexpected test failures (it shouldn't), shortly it will be merged and automatically resolved.
You don't have to do anything since it's all automated.
Assignee | ||
Comment 8•4 years ago
|
||
Thanks a lot to both of you for the explanation. Looking forward to contribute more to the project :)
Comment 9•4 years ago
|
||
bugherder |
Description
•