Closed
Bug 1674869
Opened 4 years ago
Closed 4 years ago
Perf tweaks for XDRScriptStencil
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
ScriptStencils are numerous in XDR buffers since they include lazy and non-lazy scripts. Reducing the transcoding overhead is beneficial here.
|
Assignee | |
Comment 1•4 years ago
|
||
Now that XDR checks for correct endianness, we can use codeBytes for more
complex structures. We also move the function to StencilXdr namespace.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e718fb591e8
Cleanup XDRScriptStencil to improve perf. r=arai
|
||
Comment 3•4 years ago
|
||
Backed out 4 changesets (bug 1674674, bug 1674869) for build bustage in gecko/js/src/frontend/StencilXdr.cpp. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=320586330&repo=autoland&lineNumber=13792
Push that introduced failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=124f2166945377d87339b99e7c468122caa76052
Backout:
https://hg.mozilla.org/integration/autoland/rev/e08cd4a3c8157686e168d48472a6fe501f3c7157
Flags: needinfo?(tcampbell)
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/706d08dc9e94
Cleanup XDRScriptStencil to improve perf. r=arai
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(tcampbell)
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•