Closed Bug 1675084 Opened 4 years ago Closed 4 years ago

Warp: Make transpiled call instructions depend on argument guards

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: iain, Assigned: iain)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1675084: Ensure call node depends on guards r=jandem
(deleted), text/x-phabricator-request
Details

When we transpile a call, we may also transpile guards on some of the arguments. (For example, we guard that the argument to a funapply is a packed array.) When we generate the actual call node, however, we use the original values of the arguments, not the guarded values. Among other things, this can cause us to insert unnecessary fallible unboxes.

Summary: Warp: Maketranspiled call instructions depend on argument guards → Warp: Make transpiled call instructions depend on argument guards
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c971c088ab13 Ensure call node depends on guards r=jandem

https://hg.mozilla.org/mozilla-central/rev/c971c088ab13

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: