Closed Bug 1675266 Opened 4 years ago Closed 4 years ago

Add debuggerAddress as attribute on the Remote Agent interface

Categories

(Remote Protocol :: Agent, task, P1)

Product:
Remote Protocol
Component:
Agent
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

Bug 1675266 - [remote] Add debuggerAddress as attribute on the Remote Agent interface.
(deleted), text/x-phabricator-request
Details
Bug 1675266 - [remote] Report correct browser name/version, and user agent string for "/json/version" httpd handler.
(deleted), text/x-phabricator-request
Details

We would like to send the debuggerAddress of the Remote Agent via the capabilities in Marionette (bug 1671205). As such we need it's location to be shared, and as best on the interface so that Marionette can easily query for it.

Priority: P2 → P1
Summary: Add debuggerAddress as property on the Remote Agent interface → Add debuggerAddress as attribute on the Remote Agent interface

To allow other components in Firefox to easily find the address
under which the Remote Agent is accessible, add the host and port
information as "debuggerAddress" to the Remote Agent's interface
definition.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fd5c9f2bd29 [remote] Add debuggerAddress as attribute on the Remote Agent interface. r=remote-protocol-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/04e39b99f9c4 [remote] Report correct browser name/version, and user agent string for "/json/version" httpd handler. r=remote-protocol-reviewers,maja_zf
Backout by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9beb63cb0d1 Backed out 3 changesets (bug 1675266, bug 1671205) for failures on test_capabilities.js. CLOSED TREE

Here the missing link to the Treeherder view:

https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&tochange=f9beb63cb0d1e12985fa7fef150ef23989bd0aae&fromchange=a1900289bdac31b543a5d4e46cbd7aae22599a0e

Problem here for Android is that I missed that the Remote Agent is not available on that platform. Also I missed that the same applies to release builds of Firefox. I will have to get the Marionette xpcshell tests fixed.

The failing TV job on Mac debug webrender can stay given that it will drastically improve the reproduction steps and will help us to get bug 1663533 fixed.

Blocks: 1663533

Note that I will just re-land the patches on this bug, and do the necessary Marionette fixes over on bug 1671205.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd12a0bec46f [remote] Add debuggerAddress as attribute on the Remote Agent interface. r=remote-protocol-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/15713ccc419b [remote] Report correct browser name/version, and user agent string for "/json/version" httpd handler. r=remote-protocol-reviewers,maja_zf

https://hg.mozilla.org/mozilla-central/rev/dd12a0bec46f
https://hg.mozilla.org/mozilla-central/rev/15713ccc419b

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: