Closed Bug 1676537 Opened 4 years ago Closed 4 years ago

Perma [tier2] /builds/worker/checkouts/gecko/browser/app/winlauncher/test/TestCrossProcessWin.cpp:16:16: error: definition of type 'FILE_BASIC_INFORMATION' conflicts with typedef of the same name

Categories

(Firefox :: Launcher Process, defect, P5)

Product:
Firefox
Component:
Launcher Process
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Project Flags:
Root Cause Coding: Syntax Error
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- unaffected
firefox83 --- unaffected
firefox84 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: toshi)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1676537 - Do not define FILE_BASIC_INFORMATION in MinGW build. r=mhowell
(deleted), text/x-phabricator-request
Details

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=321388295&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UseiRBjESriC_61edfdpXw/runs/0/artifacts/public/logs/live_backing.log

[task 2020-11-10T23:28:26.316Z] 23:28:26  WARNING -  /builds/worker/checkouts/gecko/security/sandbox/chromium/base/optional.h:422:7: warning: __declspec attribute 'empty_bases' is not supported [-Wignored-attributes]
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -  class OPTIONAL_DECLSPEC_EMPTY_BASES Optional
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -        ^
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -  /builds/worker/checkouts/gecko/security/sandbox/chromium/base/optional.h:397:50: note: expanded from macro 'OPTIONAL_DECLSPEC_EMPTY_BASES'
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -  #define OPTIONAL_DECLSPEC_EMPTY_BASES __declspec(empty_bases)
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -                                                   ^
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -  2 warnings generated.
[task 2020-11-10T23:28:26.316Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/sandbox'
[task 2020-11-10T23:28:26.322Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/common'
[task 2020-11-10T23:28:26.322Z] 23:28:26     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-clang++ -std=gnu++17 -o appendable.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_HAVE_NL_LANGINFO_CODESET=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-build/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -fno-strict-aliasing -Wno-incompatible-ms-struct -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti -Wno-c++20-compat -Wno-comma -Wno-implicit-const-int-float-conversion -Wno-macro-redefined -Wno-microsoft-include -Wno-tautological-unsigned-enum-zero-compare -Wno-unreachable-code-loop-increment -Wno-unreachable-code-return -fexperimental-new-pass-manager  -MD -MP -MF .deps/appendable.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/appendable.cpp
[task 2020-11-10T23:28:26.323Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/icu/common'
[task 2020-11-10T23:28:26.324Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/common'
[task 2020-11-10T23:28:26.325Z] 23:28:26     INFO -  config/external/icu/common/bmpset.o
[task 2020-11-10T23:28:26.325Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/icu/common'
[task 2020-11-10T23:28:26.341Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/nspr/ds'
[task 2020-11-10T23:28:26.341Z] 23:28:26     INFO -  mkdir -p '.deps/'
[task 2020-11-10T23:28:26.341Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/nspr/ds'
[task 2020-11-10T23:28:26.357Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'
[task 2020-11-10T23:28:26.357Z] 23:28:26     INFO -  mkdir -p '.deps/'
[task 2020-11-10T23:28:26.357Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'
[task 2020-11-10T23:28:26.380Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'
[task 2020-11-10T23:28:26.380Z] 23:28:26     INFO -  config/external/icu/i18n/astro.o
[task 2020-11-10T23:28:26.380Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/browser/app/winlauncher/test'
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/x86_64-w64-mingw32-clang++ -std=gnu++17 -o TestCrossProcessWin.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/browser/app/winlauncher/test -I/builds/worker/workspace/obj-build/browser/app/winlauncher/test -I/builds/worker/checkouts/gecko/browser/app/winlauncher -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/testing -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -fno-strict-aliasing -Wno-incompatible-ms-struct -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -fexperimental-new-pass-manager  -MD -MP -MF .deps/TestCrossProcessWin.o.pp   /builds/worker/checkouts/gecko/browser/app/winlauncher/test/TestCrossProcessWin.cpp
[task 2020-11-10T23:28:26.469Z] 23:28:26    ERROR -  /builds/worker/checkouts/gecko/browser/app/winlauncher/test/TestCrossProcessWin.cpp:16:16: error: definition of type 'FILE_BASIC_INFORMATION' conflicts with typedef of the same name
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  typedef struct FILE_BASIC_INFORMATION {
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -                 ^
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/winternl.h:427:5: note: 'FILE_BASIC_INFORMATION' declared here
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -    } FILE_BASIC_INFORMATION, *PFILE_BASIC_INFORMATION;
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -      ^
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  1 error generated.
[task 2020-11-10T23:28:26.469Z] 23:28:26    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: TestCrossProcessWin.o] Error 1
[task 2020-11-10T23:28:26.469Z] 23:28:26     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/app/winlauncher/test'```
Flags: needinfo?(tkikuchi)

Ah, I forgot to check MinGW again... Thanks.

Assignee: nobody → tkikuchi
Root Cause: --- → Coding: Syntax Error
Regressed by: 1659438
Has Regression Range: --- → yes
Keywords: regression
Summary: Intermittent perma [tier2] /builds/worker/checkouts/gecko/browser/app/winlauncher/test/TestCrossProcessWin.cpp:16:16: error: definition of type 'FILE_BASIC_INFORMATION' conflicts with typedef of the same name → Perma [tier2] /builds/worker/checkouts/gecko/browser/app/winlauncher/test/TestCrossProcessWin.cpp:16:16: error: definition of type 'FILE_BASIC_INFORMATION' conflicts with typedef of the same name

Set release status flags based on info from the regressing bug 1659438

status-firefox82: --- → unaffected
status-firefox83: --- → unaffected
status-firefox84: --- → affected
status-firefox-esr78: --- → unaffected
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b13df89f0786 Do not define FILE_BASIC_INFORMATION in MinGW build. r=mhowell
Blocks: mingw-clang

https://hg.mozilla.org/mozilla-central/rev/b13df89f0786

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: needinfo?(tkikuchi)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: