Closed
Bug 1676797
Opened 4 years ago
Closed 4 years ago
Replace MOZ_MUST_USE with [[nodiscard]] in docshell
Categories
(Core :: DOM: Navigation, task, P3)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
84 Branch
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute((warn_unused_result))__. Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
|
Assignee | |
Comment 1•4 years ago
|
||
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a8c97ac2942 Replace MOZ_MUST_USE with [[nodiscard]] in docshell. r=smaug
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•