Closed
Bug 1676810
Opened 4 years ago
Closed 4 years ago
Introduce a shared module to maintain cross-process/cross-thread "watched data"
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox85 fixed)
RESOLVED
FIXED
85 Branch
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In bug 1573327, I'm about to introduce a new "watched data": breakpoints.
And this will require slightly more complex logic when it comes to add and remove entries.
The entries will no longer be primitive objects (typically a string), but will now be JS objects with sub attributes. This will force to use something more complex than Array.includes(entry)
and Array.findIndex(entry)
.
And this isn't super obvious today, but we have two callsites which maintain the WatchedData:
- WatcherRegistry:
https://searchfox.org/mozilla-central/rev/50215d649d4854812837f1343e8f47bd998dacb5/devtools/server/actors/watcher/WatcherRegistry.jsm#165-178 - DevToolsWorkerChild
https://searchfox.org/mozilla-central/rev/50215d649d4854812837f1343e8f47bd998dacb5/devtools/server/connectors/js-window-actor/DevToolsWorkerChild.jsm#447-450
So, it would be handy to have these two code use a shared piece of code in order to later tweak its implementation in bug 1573327.
Assignee | ||
Comment 1•4 years ago
|
||
This will allow to better handle more complex data like breakpoints.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0ff2113d5b1 [devtools] Use a shared WatchedData module in order to update cross process data object. r=jdescottes
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•