https://searchfox.org/comm-central/rev/47359f1d9b32d1f35c969409511309d8f4762b63/mail/extensions/openpgp/content/modules/compat.jsm

This doesn't seem to do anything useful. All the services can be called directly, and the tree stuff is for old versions of Thunderbird.

Replace EnigmailCompat.generateQI with ChromeUtils.generateQI

find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.generateQI/ChromeUtils.generateQI/g' {} ;

Delete lazy import lines

find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E '/EnigmailCompat: "chrome://openpgp/content/modules/compat.jsm"/d' {} ;

EnigmailCompat.copyFileToMailFolder -> MailServices.copy.CopyFileMessage

+ then manually adjust the arguments

find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.copyFileToMailFolder/MailServices.copy.CopyFileMessage/g' {} ;

EnigmailCompat.getUrlFromUriSpec: move this function to EnigmailFuncs, mail/extensions/openpgp/content/modules/funcs.jsm

find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.getUrlFromUriSpec/EnigmailFuncs.getUrlFromUriSpec/g' {} ;

EnigmailCompat.getExistingFolder -> MailUtils.getExistingFolder

find mail -type f -not -path ".hg/" -regex ".*.(jsm|js)$" -exec sed -i -E 's/EnigmailCompat.getExistingFolder/MailUtils.getExistingFolder/g' {} ;

getTreeCompatibleFuncs: manually change to operate on the tree and not on the functs (which just wrapped the functions)

FeedUtils had copy of the same functionality. Perhaps the function should be moved somewhere else, but we're not even hooking up the keyserver atm so it's for the moment unused code.

Depends on D111421

Depends on D111425

Depends on D111544

Depends on D111545

We're not using anything from the enigmail.properties file, since everything was converted to Fluent.
Inlining the strings now so we know what they were, in case some of them are needed in the future.

I assume this was used for something more at some point in the past. At the moment, it doesn't appear to do much.
Nothing was every pushed to createdURIs.

For the buggy exchange message, it appears we always just display blank now until we can decrypt. The message that (maybe?) was intended to show, I don't see ever getting accessed.

Depends on D127939

Depends on D127942

Remove temp dir handling (temp dir must always exist), and also a few other methods never used anymore.

Only use in uncommented code...

This makes the cases that were already in async contexts use normal async/await instead,
and makes some easy-to-convert functions to async as well.

Remaining cases are harder and may each require more work.

It's possible Thunderbird should also have some functionality to remind about expiring keys, but I don't think this would be it.
I don't understand why the recommendation has been to create a new key. Wouldn't it be better to extend the validity?

Inlined and slight cleaned up into the one uncommnented (and very broken) use case...

Removing EnigmailFiles required making more functions async, so fixing it rippled a bit.

Making things async changed some timings slightly, which caused some test failures.
I located and fixed a few such problems, where async methods were not properly awaited.

Depends on D133947

Removed the whenDoneDB param and made proper use of the functions being async instead.
Fixes some minor buggy behavior as well.

(In reply to Magnus Melin [:mkmelin] from comment #40)

Created attachment 9255584 [details]
Bug 1677088 - convert EnigmailFiles to using IOUtils. r=PatrickBrunschwig

This patch introduced (at least) regression bug 1778509.

Code that previously used binary file reading, and that expected to handle binary files, was converted to use readUTF8.

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/1a1d2a8fd6ff
Remove some dead code in EnigmailMime. r=kaie