Closed Bug 1677253 Opened 4 years ago Closed 3 years ago

Fix <input>/<textarea> selection setters/methods always firing a select event regardless of its current selection range

Tracking

()

Status:

RESOLVED FIXED

Milestone:

91 Branch

Tracking Flags:

Tracking

Status

firefox91

---

fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(3 files)

Bug 1677253 - Part 1: Fire select event from SelectionChangeEventDispatcher r=masayuki 4 years ago Kagami [:saschanaz] (they/them, PTO until 2023-09-10) (deleted), text/x-phabricator-request		Details
Bug 1677253 - Part 2: Detect direction change in SelectionChangeEventDispatcher r=masayuki 4 years ago Kagami [:saschanaz] (they/them, PTO until 2023-09-10) (deleted), text/x-phabricator-request		Details
Bug 1677253 - Part 3: Update test r=masayuki 4 years ago Kagami [:saschanaz] (they/them, PTO until 2023-09-10) (deleted), text/x-phabricator-request		Details

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Description

•

4 years ago

Covered by WPT.

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

URL: http://w3c-test.org/html/semantics/fo...

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1677254

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Severity: -- → S3

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1679424

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Blocks: 1679427

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Summary: Fix input.select() always firing a select event regardless of its current selection range → Fix <input>/<textarea> selection setters/methods always firing a select event regardless of its current selection range

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Depends on: 1681615

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Depends on: 1682706

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Comment 3

•

4 years ago

Attached file Bug 1677253 - Part 1: Fire select event from SelectionChangeEventDispatcher r=masayuki (deleted) — Details

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Comment 4

•

4 years ago

Attached file Bug 1677253 - Part 2: Detect direction change in SelectionChangeEventDispatcher r=masayuki (deleted) — Details

Depends on D101245

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Comment 5

•

4 years ago

Attached file Bug 1677253 - Part 3: Update test r=masayuki (deleted) — Details

Depends on D101246

Pulsebot

Comment 6

•

4 years ago

Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/171689d8d386 Part 1: Fire select event from SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/aabba45e0b43 Part 2: Detect direction change in SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/01b34d4be08c Part 3: Update test r=masayuki

Razvan Maries

Comment 7

•

4 years ago

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=P7pXX1sfSgyAOPpD0yT9og.0&revision=ec3d60a618670ef6bbd233c0ef27865cc968709e&failure_classification_id=2

Logs
https://treeherder.mozilla.org/logviewer?job_id=326459847&repo=autoland&lineNumber=4968
https://treeherder.mozilla.org/logviewer?job_id=326458659&repo=autoland&lineNumber=6903
https://treeherder.mozilla.org/logviewer?job_id=326458751&repo=autoland&lineNumber=6761

TV failure: https://treeherder.mozilla.org/logviewer?job_id=326458052&repo=autoland&lineNumber=3142

Backout: https://hg.mozilla.org/integration/autoland/rev/1d3e13fa11ff6b4a8c99a7778675e65da2a625fc

Flags: needinfo?(krosylight)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 8

•

4 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27168 for changes under testing/web-platform/tests

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 9

•

4 years ago

Upstream PR was closed without merging

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Flags: needinfo?(krosylight)

BugBot [:suhaib / :marco/ :calixte]

Comment 10

•

4 years ago

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:saschanaz, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(krosylight)

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

4 years ago

Flags: needinfo?(krosylight)

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

3 years ago

Depends on: 1713334

Pulsebot

Comment 11

•

3 years ago

Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb6001404a57 Part 1: Fire select event from SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/1c385b21e0e5 Part 2: Detect direction change in SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/3d30a54409a7 Part 3: Update test r=masayuki

Atila Butkovits

Comment 12

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/eb6001404a57
https://hg.mozilla.org/mozilla-central/rev/1c385b21e0e5
https://hg.mozilla.org/mozilla-central/rev/3d30a54409a7

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox91: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 91 Branch

Ryan VanderMeulen [:RyanVM]

Comment 13

•

3 years ago

Backed out because it depends on bug 1713334.
https://hg.mozilla.org/mozilla-central/rev/1cf3235975588162c28e4910fa1332f4907e7c47

Status: RESOLVED → REOPENED

status-firefox91: fixed → affected

Resolution: FIXED → ---

Target Milestone: 91 Branch → ---

Ryan VanderMeulen [:RyanVM]

Updated

•

3 years ago

Flags: needinfo?(krosylight)

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Assignee

Updated

•

3 years ago

Flags: needinfo?(krosylight)

Pulsebot

Comment 14

•

3 years ago

Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9875894b59e4 Part 1: Fire select event from SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/befa93918c7a Part 2: Detect direction change in SelectionChangeEventDispatcher r=masayuki https://hg.mozilla.org/integration/autoland/rev/9daae850d882 Part 3: Update test r=masayuki

Narcis Beleuzu [:NarcisB]

Comment 15

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9875894b59e4
https://hg.mozilla.org/mozilla-central/rev/befa93918c7a
https://hg.mozilla.org/mozilla-central/rev/9daae850d882

Status: REOPENED → RESOLVED

Closed: 3 years ago → 3 years ago

status-firefox91: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → 91 Branch

Dorel Luca [:dluca]

Updated

•

3 years ago

Regressions: 1717433

Dorel Luca [:dluca]

Updated

•

3 years ago

Regressions: 1717435

Alexandru Ionescu (needinfo me) [:alexandrui]

Updated

•

3 years ago

Regressions: 1718255

Alexandru Ionescu (needinfo me) [:alexandrui]

Updated

•

3 years ago

Regressions: 1735745

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 16

•

3 years ago

Upstream PR merged by saschanaz

You need to log in before you can comment on or make changes to this bug.