Unify the primaryToolbar.css
Categories
(Thunderbird :: Theme, task)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
primaryToolbar.css is actually not unified and we have a lot of code tripled in the files.
Assignee | ||
Comment 1•4 years ago
|
||
A lot of code is now in the shared file.
I also remove unused code like .mail-bar3 in osx which is a class we don't have. Or also .appmenu-edit-button which was used in the old AppMenu.
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #2)
Comment on attachment 9188094 [details] [diff] [review]
1677538-unify-primaryToolbar.css.patchReview of attachment 9188094 [details] [diff] [review]:
Great clean up, thank you so much for doing it.
Just a little nit to remove a duplicated class declaration we don't need.This .button-appmenu { margin-inline: 4px; } can be removed from both Linux
and Windows files as it's already declared in the shared file.
Only macos needs the 7px variation.
Ah yes, good catch. Removed.
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/624e9cfcc93b
Unify the primaryToolbar.css. r=aleca
Updated•4 years ago
|
Description
•