Closed
Bug 1677657
Opened 4 years ago
Closed 4 years ago
Make js::BaseScript::{extent,immutableFlags} const
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
By tweaking how MakeDefaultConstructor works to instead plumb the SourceExtent down to the cloning code, we can make the BaseScript::extent const. Probably can also make the ImmutableFlags const too after the TI removal.
|
Assignee | |
Comment 1•4 years ago
|
||
While cloning the default constructor script from self-hosting realm, pass in
the final SourceExtent for the class. This removes the last need for the
BaseScript::extent to be modified so we can now mark it const.
Also clear the script's SelfHosted flag in the same way to avoid modifying it
after the script is created.
|
||
Updated•4 years ago
|
Attachment #9188201 -
Attachment description: Bug 1677657 - Directly set SourceExtent when cloning default class constructor → Bug 1677657 - Directly set SourceExtent when cloning default class constructor. r?jandem!
|
|
Assignee | |
Updated•4 years ago
|
Summary: Make js::BaseScript::extent const → Make js::BaseScript::{extent,immutableFlags} const
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/293b759748b9
Directly set SourceExtent when cloning default class constructor. r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•