Closed
Bug 1677688
Opened 4 years ago
Closed 4 years ago
Avoid nested property bags in Places async shutdown metadata
Categories
(Toolkit :: Async Tooling, task, P3)
Toolkit
Async Tooling
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Most of the metadata looks like:
"state":{"progress":{},"Barrier":{}}
That is quite useless. I think it's due to our use of nested property bags, thus here I'd like to change the approach copying over variants from the original property bag to the final one, hopefully we'll get better logging.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/8bdcf54531e1
Avoid nested property bags in Places async shutdown metadata. r=Standard8
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
|
||
Comment 4•4 years ago
|
||
This has been backed out for crashes with [@ mozilla::places::PlacesShutdownBlocker::GetState], e.g. bp-181e28bc-2c23-4598-b4d7-8c7cd0201121
Status: RESOLVED → REOPENED
status-firefox85:
fixed → ---
Flags: needinfo?(mak)
Resolution: FIXED → ---
Target Milestone: 85 Branch → ---
Backout by rmaries@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/31395a8cf477
Backed out changeset 8bdcf54531e1 for crashes. a=backout DONTBUILD
|
|
Assignee | |
Comment 6•4 years ago
|
||
Do you remember if the crashes were visible on treeherder? Trying to check how I can reproduce them easily.
Flags: needinfo?(mak) → needinfo?(aryx.bugmail)
|
|
||
Comment 7•4 years ago
|
||
This hasn't be observed in our automation, only on the user side. Most of the uptimes were several hours.
Crash Signature: [@ mozilla::places::PlacesShutdownBlocker::GetState]
Flags: needinfo?(aryx.bugmail)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/ceb70463432e
Avoid nested property bags in Places async shutdown metadata. r=Standard8
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•