about:config textbox has an outline by default after bug 1618639
Categories
(Toolkit :: Themes, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox83 | --- | unaffected |
firefox84 | --- | verified |
firefox85 | --- | verified |
People
(Reporter: emilio, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
After bug 1618639 <input type=text>
/ <textarea>
/ etc always match :-moz-focusring
/ :focus-visible
, and that causes the about:config
, which has outlines created via border-color
/ box-shadow
, to also get an extra outline.
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
These didn't match :-moz-focusring
by default before, but now they do
and we get an extra outline much more often, not just when navigating
with the keyboard.
While at it simplify the ::-moz-focus-inner disabling as well.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
bugherder |
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1618639
Comment 5•4 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9188257 [details]
Bug 1677705 - Disable outlines for inputs etc which have their own focus styles. r=dao,gijs
Beta/Release Uplift Approval Request
- User impact if declined: Some extra outlines show up in some cases.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: open about:config, focus the textbox.
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple css change.
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment on attachment 9188257 [details]
Bug 1677705 - Disable outlines for inputs etc which have their own focus styles. r=dao,gijs
Approved for 84.0b4.
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 9•4 years ago
|
||
Verified as fixed on the latest Nightly 85.0a1 and Firefox 84 beta 4 - on Mac OS X 10.15, Ubuntu 20.04 x64, and Windows 10 x64.
Description
•