Closed Bug 1677705 Opened 4 years ago Closed 4 years ago

about:config textbox has an outline by default after bug 1618639

Categories

(Toolkit :: Themes, defect)

defect

Tracking

()

VERIFIED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- verified
firefox85 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

After bug 1618639 <input type=text> / <textarea> / etc always match :-moz-focusring / :focus-visible, and that causes the about:config, which has outlines created via border-color / box-shadow, to also get an extra outline.

Regressed by: 1618639
Has Regression Range: --- → yes

These didn't match :-moz-focusring by default before, but now they do
and we get an extra outline much more often, not just when navigating
with the keyboard.

While at it simplify the ::-moz-focus-inner disabling as well.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c5d16660dec Disable outlines for inputs etc which have their own focus styles. r=dao
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Set release status flags based on info from the regressing bug 1618639

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9188257 [details]
Bug 1677705 - Disable outlines for inputs etc which have their own focus styles. r=dao,gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Some extra outlines show up in some cases.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: open about:config, focus the textbox.
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): simple css change.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9188257 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9188257 [details]
Bug 1677705 - Disable outlines for inputs etc which have their own focus styles. r=dao,gijs

Approved for 84.0b4.

Attachment #9188257 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed on the latest Nightly 85.0a1 and Firefox 84 beta 4 - on Mac OS X 10.15, Ubuntu 20.04 x64, and Windows 10 x64.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: