wdspec tests don't honour the --enable-webrender (and lack thereof) switch in automation
Categories
(Testing :: web-platform-tests, defect, P3)
Tracking
(Fission Milestone:M8, firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: aosmond, Assigned: jgraham)
References
(Blocks 1 open bug)
Details
Attachments
(6 files, 1 obsolete file)
|
Reporter | |
Comment 1•4 years ago
|
||
Hopefully this doesn't cause any failures in wdspec tests:
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1034e3a0e81589a0f9619051269ca5d15bedc1d9
|
|
Reporter | |
Comment 2•4 years ago
|
||
|
Assignee | |
Comment 3•4 years ago
|
||
wdspec launches Firefox using geckodriver. This was going through a
different codepath to the other wpt tests and in particular it wasn't
setting the correct environment variables.
This patch factors the environment variable setting out into a
function that can be called both when starting Firefox normally and
before invoking pytest. This isn't perfect, but does allow more code
sharing between the two paths.
|
||
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/c4756cf7f5f1 Ensure we set environment variables when running wdspec tests, r=maja_zf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26572 for changes under testing/web-platform/tests
|
|
Reporter | |
Comment 6•4 years ago
|
||
I'm still seeing the issue with wdspec tests:
I added logs:
[task 2020-11-19T16:15:41.680Z] 16:15:41 INFO - PID 911 | [AO] wr=1 sw_wr=1; ee=0 ed=0 ps=0
which show MOZ_WEBRENDER=1 wasn't set (ee=0).
|
|
Assignee | |
Comment 7•4 years ago
|
||
The previous patch set the variables too late, after the webdriver server was already
started. Pass them down into the server startup code instead
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•4 years ago
|
||
This ensures that we always pass a profile in the capabilitites. When
we're running with a single process it simply unpacks the profile to a
temporary folder and passes in that path as a firefox argument. When
we're running with multiple processes, that won't work. We could
invent a mechanism to get one profile per process, but for simplicity
we instead pass in the profile as a base64-encoded string.
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
This bug is fixed. James, should all these revisions actually be part of bug 1680963?
|
|
||
Comment 12•4 years ago
|
||
As mentioned by James this bug isn't fixed. So lets reopen. It will also block bug 1680963.
|
|
||
Updated•4 years ago
|
|
|
Reporter | |
Comment 13•4 years ago
|
||
The debug prints show we aren't getting the MOZ_WEBRENDER envvar set in the qr and non-qr variations.
Upstream PR was closed without merging
Upstream PR merged by jgraham
|
||
Comment 16•4 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e5887add977 [wpt PR 26572] - [Gecko Bug 1678044] Ensure we set environment variables when running wdspec tests, a=testonly
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 17•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 18•4 years ago
|
||
This requires passing the test_environment into the get_executor_kwargs function
so that in the firefox wdspec case we can add a cleanup function to the environment
when running wdspec tests. That seems reasonable since we were previously using
a variety of data in the environment to setup the kwargs anyway
|
|
Reporter | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 20•4 years ago
|
||
Setting Fission Milestone to M8 because this bug blocks Fission M8 bug 1680963.
|
|
||
Comment 21•3 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/659084e40ec2 Fix setting environment variables for wdspec tests, r=maja_zf,marionette-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/c5914548a084 Use correct profile for wdspec tests, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/43cf7957ed78 Fix disabling location services and new tab for geckodriver, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/708bdb00db84 Switch to explicit profile cleanup rather than using __del__, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/2f91386cca8e Unmaximize window before starting a new session, r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28640 for changes under testing/web-platform/tests
Upstream PR was closed without merging
|
||
Comment 24•3 years ago
|
||
Backout changeset for causing marionette failures at test_fission_autostart.py .
also failes here python/test_mochitest_integration.py
Failure log
|
||
Comment 25•3 years ago
|
||
Backed out 14 changesets (bug 1686707, bug 1707876, bug 1678044) for Spidermonkey failure. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=340215481&repo=autoland&lineNumber=45654
Backout:
https://hg.mozilla.org/integration/autoland/rev/532f607c9ca037bdfc9d671a7447b28b19c05c77
|
|
||
Comment 26•3 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/d5f5359358fd Fix setting environment variables for wdspec tests, r=maja_zf,marionette-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/0eeb2f149770 Use correct profile for wdspec tests, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/6aeb03df54bb Fix disabling location services and new tab for geckodriver, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/5281b7443a89 Switch to explicit profile cleanup rather than using __del__, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/023e75831c48 Unmaximize window before starting a new session, r=webdriver-reviewers,whimboo
|
|
||
Comment 27•3 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/222c0fda8126 Fix setting environment variables for wdspec tests, r=maja_zf,marionette-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/6dc4d87d1b65 Use correct profile for wdspec tests, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/1f77f1f4241f Fix disabling location services and new tab for geckodriver, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/0a5ac7d40966 Switch to explicit profile cleanup rather than using __del__, r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/98347e378726 Unmaximize window before starting a new session, r=webdriver-reviewers,whimboo
|
|
||
Comment 28•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/222c0fda8126
https://hg.mozilla.org/mozilla-central/rev/6dc4d87d1b65
https://hg.mozilla.org/mozilla-central/rev/1f77f1f4241f
https://hg.mozilla.org/mozilla-central/rev/0a5ac7d40966
https://hg.mozilla.org/mozilla-central/rev/98347e378726
Upstream PR merged by jgraham
|
|
||
Comment 30•3 years ago
|
||
James, I think that we can close this bug now, right? If not please reopen.
|
|
||
Comment 31•3 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/394dc041d6f5 [wpt PR 28640] - [Gecko Bug 1678044] Fix setting environment variables for wdspec tests, a=testonly
|
|
||
Comment 32•3 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5257b1387889 [wpt PR 28640] - [Gecko Bug 1678044] Fix setting environment variables for wdspec tests, a=testonly
|
|
||
Comment 33•3 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b2ea8650148 [wpt PR 28640] - [Gecko Bug 1678044] Fix setting environment variables for wdspec tests, a=testonly
|
||
Comment 34•3 years ago
|
||
| bugherder | ||
|
|
||
Updated•1 year ago
|
Description
•