Closed Bug 1678391 Opened 4 years ago Closed 4 years ago

3.94 - 4.78% kraken (linux64-shippable-qr, macosx1014-64-shippable-qr, windows10-64-shippable-qr, windows7-32-shippable) regression on push 6c51def942690aa7f708acbed22800abf5b4f784 (Wed November 11 2020)

Categories

(Core :: JavaScript Engine, defect, P2)

Product:
Core
Component:
JavaScript Engine
Version:
Firefox 85
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1677782
Tracking Flags:
Tracking Status
firefox85 --- fixed
firefox86 --- fixed

People

(Reporter: alexandrui, Assigned: iain)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push 6c51def942690aa7f708acbed22800abf5b4f784. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
5% kraken windows7-32-shippable e10s stylo 1,423.08 -> 1,491.07
5% kraken macosx1014-64-shippable-qr e10s stylo webrender 1,560.95 -> 1,634.29
4% kraken linux64-shippable-qr e10s stylo webrender 1,274.01 -> 1,326.72
4% kraken windows10-64-shippable-qr e10s stylo webrender 1,343.25 -> 1,396.14

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(daisuke)
Component: Performance → Address Bar
Product: Testing → Firefox

The revision of your push in autoland has a broken build, but I did a local backout of the code that broke the build and the comparison (search for kraken to find it easier) reveals your patch.

it's honestly very strange that a simple change to the urlbar logic regresses Kraken

I'm sorry, I just tagged the wrong bug :(

Regressed by: 1673497
No longer regressed by: 1676054
Has Regression Range: --- → yes
Summary: 3.94 - 4.78% kraken (linux64-shippable-qr, macosx1014-64-shippable-qr, windows10-64-shippable-qr, windows7-32-shippable) regression on push 84780a4376d6791bf1ea75f8e47078a979fefd79 (Wed November 11 2020) → 3.94 - 4.78% kraken (linux64-shippable-qr, macosx1014-64-shippable-qr, windows10-64-shippable-qr, windows7-32-shippable) regression on push 6c51def942690aa7f708acbed22800abf5b4f784 (Wed November 11 2020)
Flags: needinfo?(daisuke)

Forwarding to Iain..

Flags: needinfo?(jdemooij) → needinfo?(iireland)
Component: Address Bar → JavaScript Engine
Product: Firefox → Core

This might be a duplicate of bug 1677782. Taking a look.

Assignee: nobody → iireland
Flags: needinfo?(iireland)
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.