The SSO No Phishing addon causes my 2019 15" MBP running macOS 11.0.1 to lockup and reboot. I've had this happen with Firefox release 83.0 as well as Dev Edition 84.0b2. I have not yet figured out why this is happening, but it has been reproduced by others.

I also filed an issue with the addon, but the problem is really with Firefox as an addon shouldn't be able to crash the machine.

STR:

1. Upgrade a Mac to Big Sur
2. Start Firefox release channel with a fresh profile
3. Update "Enhanced Tracking Protection" setting to "Strict"
4. Install SSO No Phishing addon
5. Login to mozilla services (e.g. mana or gmail) via SSO and browse around for a while.

It doesn't always happen immediately.

I'm guessing we don't get crash reports when a kernel panic happens.

Steven, is there any kernel-crash related to bug 1648487? Any other hints how we might triage this, since this is unlikely to be an extensions bug.

Unbelievably, I was able to reproduce this on both 11.0.1 (20B28) and now on 11.1 Beta (20C5048k). I didn't even have to adjust Enhanced Tracking Protection in step 3. Installing and enabling the SSO No Phishing addon was all that was needed. I don't know that there is much that we can collect besides the macOS crash report and submit it to Apple. Markus, have you dealt with kernel panics caused by Firefox before? Any suggestions on how to isolate this any further?

Wow. No, I have not had to deal with kernel panics caused by Firefox before. Let's get this escalated asap.

I was able to reproduce this as well. I'm guessing that it might have to do something with the UI styling that the add-on applies, with the browser.theme.update calls in background.js. Maybe we're toggling window opacity or vibrancy areas in a way that the window server doesn't like, or maybe it's something about the OpenGL commands during painting / compositing that the OpenGL driver doesn't like.

I'll try to find out whether turning off WebRender works around this bug.

I haven't had any kernel panics with WR off so far. Stephen, Paul, can you check whether this workaround is effective for you, too? Go to about:config and set gfx.webrender.force-disabled to true.

I set that pref and reinstalled the addon and logged into mana, then as I was typing an update here it crashed again. Did I need to restart Firefox for the pref update to take affect? Because that might be the case I'm leaving it all setup after that crash to see if it happens again. I'll report back if it happens again.

Aaaaaand it just crashed again. Happened when I switched back to Firefox and was about to open a new tab. Doesn't always happen when actively doing anything with SSO login or when the theme has switched to the green one to indicate the valid SSO domain. It can happen most any time it seems, but only when I'm using Firefox.

Yes, same here. Force-disabling webrender and restarting Firefox didn't prevent the crash for me either.

Thanks for checking! Yes, the WR pref requires a restart, but it seems WR has now been ruled out as a cause.

Markus, should I file a report through the Feedback Assistant and email Michael? Or were you already on it?

Thanks for jumping on this Stephen and Markus. Should we set some tracking flags, and/or move the bug to a better component, or do we need more info still?

(In reply to Tomislav Jovanovic :zombie from comment #1)

Steven...

And apologies for misspelling your name in the rush of the triage meeting! :(

(In reply to Stephen A Pohl [:spohl] from comment #10)

Markus, should I file a report through the Feedback Assistant and email Michael? Or were you already on it?

I'll do it. I have actually started writing up the feedback twice, but was playing with different ways to reproduce it, so I kept losing what I had written to a kernel panic...

I've been trying to find a way to reproduce the bug without using the add-on, by switching between various themes in the Customize dialog. No luck so far.

I've filed FB8924304 and notified Apple.

FB8924304: Kernel panic while using Firefox

System Crashes/Unexpected Reboot
Application Crash
Unexpected Reboot (Restarted because of a problem)

Please describe the issue and what steps we can take to reproduce it:

This is reproducible on both 11.0.1 (20B28) and on 11.1 Beta (20C5048k).

On the Mozilla side we are tracking this in https://bugzilla.mozilla.org/show_bug.cgi?id=1678428 .

That bug report has steps to reproduce, but unfortunately the steps include accessing Mozilla-internal web pages. We can try to find alternative ways to trigger the bug, if requested.

Here are the steps to reproduce from the bug:

1. Start Firefox release channel with a fresh profile
2. Update "Enhanced Tracking Protection" setting to "Strict"
3. Install SSO No Phishing addon from https://addons.mozilla.org/en-US/firefox/addon/sso-no-phishing/
4. Login to mozilla services (e.g. mana or gmail) via SSO and browse around for a while.

Oh, I should have pointed out that I never had to access any internal pages at all to reproduce the problem. After installing the addon and enabling it for private browsing, I simply opened a new private window, loaded https://sso.mozilla.com/ without logging in to trigger the green theme appearance and waited. I tried to figure out if I had to switch between windows or apps, if it mattered if the mouse was hovering over the tab bar or the tab close button, but I couldn't narrow it down further. I would always eventually crash. I never had to wait more than a minute or so to reproduce the crash.

Thank you for filing this with Apple!

Thanks! I've added that information to the Apple report.

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Can you check whether this is fixed in macOS 11.1?

(In reply to Markus Stange [:mstange] from comment #18)

Can you check whether this is fixed in macOS 11.1?

Sure. I've reinstalled the addon and will report back if it happens again.

I've had it installed and working for a few days now and have not experienced a crash. Perhaps you're right that a macOS or Firefox update has fixed the issue.

Thanks for checking! It's much more likely that the macOS update fixed it, than a Firefox update.