Closed Bug 1678623 Opened 4 years ago Closed 3 years ago

Convert onItemChanged("title") to a bookmark-title-changed PlacesEvent

Categories

(Toolkit :: Places, task, P3)

Product:
Toolkit
Component:
Places
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Iteration:
87.1 - Jan 25 - Feb 7
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mak, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1678623: Implement a mechanism to fire bookmark-title-changed event.
(deleted), text/x-phabricator-request
Details
Bug 1678623: Apply bookmark-title-changed event.
(deleted), text/x-phabricator-request
Details

onItemChanged() for "title" can be converted into its own event, derived from PlacesBookmark.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 87.1 - Jan 25 - Feb 7
Points: --- → 3

Depends on D103147

Daisuke, did you plan to ask for review on these, or are them still wip?

Flags: needinfo?(daisuke)

Hi Marco!
I was ready to request review, but had not rebased for a while.
If rebasing is successful, I will ask to review.
Thanks!

Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4b915555ae3d Implement a mechanism to fire bookmark-title-changed event. r=mak https://hg.mozilla.org/integration/autoland/rev/2d75255c3a30 Apply bookmark-title-changed event. r=mak

https://hg.mozilla.org/mozilla-central/rev/4b915555ae3d
https://hg.mozilla.org/mozilla-central/rev/2d75255c3a30

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Blocks: 1734048
Regressions: 1746739
Regressions: 1746814
Blocks: 1733045
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: