Currently, when RemoteSecuritySettings downloads multiple new stashes, it will add the first one, and reconstruct the in-memory representation of the issuer/serial hashmaps/sets, and then it will add the second one, and reconstruct the entire in-memory representation of the issuer/serial hashmaps/sets, and so on, re-doing all of the work each time. This is essentially O(n^2) work, whereas it should only require O(n).

Before this patch, when RemoteSecuritySettings would download multiple new
stashes, it would add the first one to cert_storage, which would reconstruct
the in-memory representation of all of the issuer/serial hashmaps/sets
(including preexisting ones), and then RemoteSecuritySettings would add the
second one, and cert_storage would reconstruct the entire in-memory
representation of the issuer/serial hashmaps/sets again, and so on, re-doing
all of the work each time. This is essentially O(n^2) work. This patch improves
both RemoteSecuritySettings and cert_storage to minimize this work, reducing it
to O(n).

https://hg.mozilla.org/mozilla-central/rev/b71f966519f1

Comment on attachment 9189293 [details]
Bug 1678762 - crlite: be more efficient about processing new stashes r?kjacobs

Beta/Release Uplift Approval Request

• User impact if declined: Periodic heavy CPU usage when processing new CRLite stashes.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small change, covered by automated tests.
• String changes made/needed:

Comment on attachment 9189293 [details]
Bug 1678762 - crlite: be more efficient about processing new stashes r?kjacobs

Thanks for including tests. Approved for 84.0b8.

https://hg.mozilla.org/releases/mozilla-beta/rev/6f0d469123ac