Replace MOZ_MUST_USE with [[nodiscard]] in StreamFilterParent
Categories
(WebExtensions :: Request Handling, task, P3)
Tracking
(firefox-esr78 wontfix, firefox83 wontfix, firefox84 wontfix, firefox85 fixed)
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute((warn_unused_result))__. Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
|
Assignee | |
Comment 1•4 years ago
|
||
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba96687ff42f Replace MOZ_MUST_USE with [[nodiscard]] in StreamFilterParent. r=mixedpuppy
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•