Open Bug 1679275 Opened 4 years ago Updated 4 years ago

Improve rust code in `contains` and `touch-action` parsing/serialization

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

People

(Reporter: kats, Unassigned, Mentored)

References

Details

Follow-up from https://phabricator.services.mozilla.com/D97650#3170353 - emilio had some suggestions to improve the rust parsing/serialization code for the touch-action property. Since that code was copied from the equivalent code for the contains property which should be fixed similarly, I'm filing this as a follow-up bug.

Emilio's comments from phabricator:

I would make these tests *self == TouchAction::AUTO and same for the NONE and
MANIPULATION variants (as we don't expect them to appear mixed with other flags.

But otherwise, intersects() may be marginally more efficient / descriptive to test "has this
value", both here and below.
[...]
Do you need the _cloned() version? (if so that's fine)

You need to log in before you can comment on or make changes to this bug.