view_source.editor.external stopped working
Categories
(Toolkit :: View Source, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox83 | --- | unaffected |
| firefox84 | + | fixed |
| firefox85 | + | fixed |
People
(Reporter: bugzilla, Assigned: timhuang)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0
Steps to reproduce:
Firefox developer edition 84.0b5 (64-bit) on Windows
Set view_source.editor.external to true
Set view_source.editor.path to C:\Program Files (x86)\Notepad++\notepad++.exe
Open a site and hit CTRL-U
Actual results:
The source opened in a tab
Expected results:
The source should have opened in the external editor (notepad++) like it used to in previous versions.
|
||
Comment 1•4 years ago
|
||
[Tracking Requested - why for this release]: The feature is broken
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e12b84262d8b4a09cd91f094436dc5edda03c39d&tochange=e93201b4e9087963e449099650d63bdb3dcbb2c2
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D98053
|
||
Updated•4 years ago
|
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4b69ddb28638
https://hg.mozilla.org/mozilla-central/rev/ea06934f0213
|
|
Assignee | |
Comment 6•4 years ago
|
||
Comment on attachment 9189962 [details]
Bug 1679489 - Fixing the issue that cookieJarSettings cannot be fetched from the browser. r?dimi!
Beta/Release Uplift Approval Request
- User impact if declined: The view_source.editor.external would break
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is just a one-line change. And it doesn't change the behavior.
- String changes made/needed: None
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9189962 [details]
Bug 1679489 - Fixing the issue that cookieJarSettings cannot be fetched from the browser. r?dimi!
Approved for 84.0b7. Thanks for including tests.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
Description
•