No auto-complete from Outlook address book (skip straight to comment #4)
Categories
(Thunderbird :: Address Book, enhancement)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: it, Assigned: it)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0
Steps to reproduce:
Following http://kb.mozillazine.org/Using_Outlook_and_OE_contacts_with_Thunderbird_or_Mozilla_Mail
we have configured Thunderbird access to the Outlook address book by setting these preferences:
Add the string "ldap_2.servers.Outlook.description" , setting it to "Outlook"
Add the integer ldap_2.servers.Outlook.dirType , settiung it to 3.
Add the string "ldap_2.servers.Outlook.uri" , setting it to "moz-aboutlookdirectory://op/"
Actual results:
With this configuration, addresses from the Outlook address book show up in an "OP Contacts" address book, but this address book is displayed twice, the second one is empty. When clicking on the empty one, there is an error in the Error Console.
When composing an e-mail, no suggestions are derived from the Outlook address book, however, recipients can be added via the contacts sidebar (F9).
Expected results:
- Outlook address book should only be listed once.
- Suggestions should have been derived.
Most likely in company environments this will be a common scenario.
Assignee | ||
Comment 1•4 years ago
|
||
Update: We've been looking into this some more, both in version 78.5.1 and Daily.
So the "doubled-up" address book seems to be a misconfiguration in Outlook, it doesn't happen on another PC. There are two (test) address books, one with two entries, the other one empty. The hiccup happens on the empty one. We've identified an issue with the TbSync add-on (chrome://eas4tbsync/content/overlays/abServerSearch.js) which causes the error we mentioned in the original report.
However, we also see this and more in a Daily in a profile without any add-ons installed:
Uncaught TypeError: can't access property "children", this._rowMap[aIndex] is undefined isContainer chrome://messenger/content/jsTreeView.js:90
Uncaught TypeError: can't access property "getProperties", this._rowMap[aRow] is undefined getRowProperties chrome://messenger/content/jsTreeView.js:67
Uncaught TypeError: can't access property "children", this._rowMap[aIndex] is undefined isContainer chrome://messenger/content/jsTreeView.js:90
Additionally we filed bug 1680923.
Assignee | ||
Comment 2•4 years ago
|
||
We located the second Outlook address book, is was due to an additional connected PST file. After filling in a contact there, Thunderbird in version 78.5.1 and Daily worked normally, so perhaps there is a corner case with an empty connected Outlook address book.
So in summary, this appears to be an enhancement request to support auto-complete also from connected Outlook address books.
Sorry about the added confusion, but by the looks of it, we can only edit the summary but not edit comments to remove unrelated information.
Assignee | ||
Comment 3•4 years ago
|
||
Filed bug 1680952 for the issue with the empty address book mentioned in comment #1.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
This was an easy fix. Sorry about the confusion since on the way here we ran into bug 1680952, bug 1680923 and bug 1681824, all which are fixed or have a proposed fix.
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Comment on attachment 9192852 [details] [diff] [review]
1679525-enable-auto-complete.patch
I'm not sure why this is hard-wired to false, but hard-wiring it to true is also bad – it needs to respect the auto-complete preferences (global and per-directory). Just remove the overriding method and fall back to the one in nsAbDirProperty which does it all for you.
Assignee | ||
Comment 6•4 years ago
|
||
That works, too. Thanks for the review and suggestion.
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fd498efbb53c
Enable auto-complete for Outlook address books by using default method for UseForAutocomplete(). r=darktrojan
Assignee | ||
Comment 8•4 years ago
|
||
BTW, auto-complete was disabled in bug 535528:
https://hg.mozilla.org/comm-central/rev/2254e41e8a2011086f3f01bcb8a25681716a067d
Updated•4 years ago
|
Description
•