Closed Bug 1680031 Opened 4 years ago Closed 4 years ago

Abort operations for given directory lock ids

Tracking

()

Status:

RESOLVED FIXED

Milestone:

85 Branch

Tracking Flags:

Tracking

Status

firefox85

---

fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(10 files)

Bug 1680031 - QM: Give ids to all directory locks; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - Introduce Client::AbortAllOperations; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - LSNG: Various cleanup related to abort operations methods; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - IDB: Change InvalidateLiveDatabasesMatching to a free function; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - SDB: Change AllowToCloseConnectionsMatching to a free function; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details
Bug 1680031 - Abort operations for given directory lock ids; r=#dom-workers-and-storage-reviewers 4 years ago Jan Varga [:janv] (deleted), text/x-phabricator-request		Details

Jan Varga [:janv]

Assignee

Description

•

4 years ago

Currently, when an origin is being cleared we go through the directory locks which block the clear operation and collect clients which need to be notified with AbortOperations(aOrigin).
However, this aborts all operations for given origin. The clear operation can now only clear data for given persistence type or client type. So we need to abort operations for given directory locks (instead for given origin), otherwise we can end up aborting operations for storages which are not about to be cleared.
I want to convert OpenDirectory to use MozPromise instead of a custom listener and this bug needs to be done first
Finally, I plan to use MozPromise for the asynchronous initialization methods, so if OpenDirectory uses that too, we can probably chain all that in a nice way.

Jan Varga [:janv]

Assignee

Comment 1

•

4 years ago

Attached file Bug 1680031 - QM: Give ids to all directory locks; r=#dom-workers-and-storage-reviewers (deleted) — Details

Jan Varga [:janv]

Assignee

Comment 2

•

4 years ago

Attached file Bug 1680031 - Introduce Client::AbortAllOperations; r=#dom-workers-and-storage-reviewers (deleted) — Details

Client::AbortOperations no longer supports the case when an empty origin string
is passed (which was used to abort all operations).

Depends on D98343

Jan Varga [:janv]

Assignee

Comment 3

•

4 years ago

Attached file Bug 1680031 - LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=#dom-workers-and-storage-reviewers (deleted) — Details

These methods are only used in QuotaClient class, so they don't need to be global.

Depends on D98344

Jan Varga [:janv]

Assignee

Comment 4

•

4 years ago

Attached file Bug 1680031 - LSNG: Various cleanup related to abort operations methods; r=#dom-workers-and-storage-reviewers (deleted) — Details

Depends on D98345

Jan Varga [:janv]

Assignee

Comment 5

•

4 years ago

Attached file Bug 1680031 - IDB: Change InvalidateLiveDatabasesMatching to a free function; r=#dom-workers-and-storage-reviewers (deleted) — Details

This is just a minor cleanup.

Depends on D98346

Jan Varga [:janv]

Assignee

Comment 6

•

4 years ago

Attached file Bug 1680031 - IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=#dom-workers-and-storage-reviewers (deleted) — Details

A minor cleanup

Depends on D98347

Phabricator Automation

Updated

•

4 years ago

Attachment #9190579 - Attachment description: Bug 1680031 - QM: Give id to all directory locks; r=#dom-workers-and-storage-reviewers → Bug 1680031 - QM: Give ids to all directory locks; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190581 - Attachment description: Bug Bug 1680031 - LSNG: Move some global methods to QuotaClient class; r=#dom-workers-and-storage-reviewers → Bug 1680031 - LSNG: Move some global methods to QuotaClient class; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190584 - Attachment description: Bug 1680031 - IDB: Pass aContentParentId by reference in AbortOperationsForProcess; r=#dom-workers-and-storage-reviewers → Bug 1680031 - IDB: Cleanup (and unification with other Client implementations) in QuotaClient class; r=#dom-workers-and-storage-reviewers

Jan Varga [:janv]

Assignee

Comment 7

•

4 years ago

Attached file Bug 1680031 - DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=#dom-workers-and-storage-reviewers (deleted) — Details

Depends on D98348

Jan Varga [:janv]

Assignee

Comment 8

•

4 years ago

Attached file Bug 1680031 - SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=#dom-workers-and-storage-reviewers (deleted) — Details

Depends on D98430

Jan Varga [:janv]

Assignee

Updated

•

4 years ago

Keywords: leave-open

Phabricator Automation

Updated

•

4 years ago

Attachment #9190584 - Attachment description: Bug 1680031 - IDB: Cleanup (and unification with other Client implementations) in QuotaClient class; r=#dom-workers-and-storage-reviewers → Bug 1680031 - IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190734 - Attachment description: Bug 1680031 - DOMCACHE: Pass manager as a reference in Manager::Factory::AbortMatching; r=#dom-workers-and-storage-reviewers → Bug 1680031 - DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190735 - Attachment description: Bug 1680031 - SDB: Cleanup (and unification with other Client implementations) in QuotaClient class; r=#dom-workers-and-storage-reviewers → Bug 1680031 - SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=#dom-workers-and-storage-reviewers

Pulsebot

Comment 9

•

4 years ago

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3f0236595b7 QM: Give ids to all directory locks; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/57ec107c7fa0 Introduce Client::AbortAllOperations; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/78f865f179f6 IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/8beb762b9dae DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/1e466374bc50 SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=dom-workers-and-storage-reviewers,sg

Phabricator Automation

Updated

•

4 years ago

Attachment #9190582 - Attachment description: Bug 1680031 - LSNG: Cleanup (and unification with other Client implementations) in QuotaClient class; r=#dom-workers-and-storage-reviewers → Bug 1680031 - LSNG: Various cleanup related to abort operations methods; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190583 - Attachment description: Bug 1680031 - IDB: Move private static methods of QuotaCLient to a uniform place; r=#dom-workers-and-storage-reviewers → Bug 1680031 - IDB: Change InvalidateLiveDatabasesMatching to a free function; r=#dom-workers-and-storage-reviewers

Phabricator Automation

Updated

•

4 years ago

Attachment #9190581 - Attachment description: Bug 1680031 - LSNG: Move some global methods to QuotaClient class; r=#dom-workers-and-storage-reviewers → Bug 1680031 - LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=#dom-workers-and-storage-reviewers

Jan Varga [:janv]

Assignee

Comment 10

•

4 years ago

Attached file Bug 1680031 - SDB: Change AllowToCloseConnectionsMatching to a free function; r=#dom-workers-and-storage-reviewers (deleted) — Details

Depends on D98345

Dorel Luca [:dluca]

Comment 11

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a3f0236595b7
https://hg.mozilla.org/mozilla-central/rev/57ec107c7fa0
https://hg.mozilla.org/mozilla-central/rev/78f865f179f6
https://hg.mozilla.org/mozilla-central/rev/8beb762b9dae
https://hg.mozilla.org/mozilla-central/rev/1e466374bc50

Pulsebot

Comment 12

•

4 years ago

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bad84766f83c LSNG: Various cleanup related to abort operations methods; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/10736db2685a IDB: Change InvalidateLiveDatabasesMatching to a free function; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/de20363fdc0f SDB: Change AllowToCloseConnectionsMatching to a free function; r=dom-workers-and-storage-reviewers,sg https://hg.mozilla.org/integration/autoland/rev/c7e3c04eb74e LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=dom-workers-and-storage-reviewers,sg

Jan Varga [:janv]

Assignee

Comment 13

•

4 years ago

Attached file Bug 1680031 - Abort operations for given directory lock ids; r=#dom-workers-and-storage-reviewers (deleted) — Details

This patch changes the way how we abort operations when clearing of data is
requested. Instead of aborting all operations for given origin, we now abort
all operations for given directory locks which are blocking clearing of data.

Depends on D98345

Jan Varga [:janv]

Assignee

Updated

•

4 years ago

Keywords: leave-open

Razvan Maries

Comment 14

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/bad84766f83c
https://hg.mozilla.org/mozilla-central/rev/10736db2685a
https://hg.mozilla.org/mozilla-central/rev/de20363fdc0f
https://hg.mozilla.org/mozilla-central/rev/c7e3c04eb74e

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox85: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 85 Branch

Simon Giesecke [:sg] [he/him]

Comment 15

•

4 years ago

The core patch has not yet landed, so reopening.

I want to convert OpenDirectory to use MozPromise instead of a custom listener and this bug needs to be done first
Finally, I plan to use MozPromise for the asynchronous initialization methods, so if OpenDirectory uses that too, we can probably chain all that in a nice way.

This is not yet done. It's not clear to me if you want to do this within this bug, or in separate bugs? In the former case, we probably still need leave-open here.

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Jan Varga [:janv]

Assignee

Comment 16

•

4 years ago

Yes, I prematurely removed the leave-open flag, sorry.

BugBot [:suhaib / :marco/ :calixte]

Updated

•

4 years ago

status-firefox85: fixed → affected

Pulsebot

Comment 17

•

4 years ago

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a8dbaa4c1bd Abort operations for given directory lock ids; r=dom-workers-and-storage-reviewers,sg

Alexandru Michis [:malexandru]

Comment 18

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0a8dbaa4c1bd

Status: REOPENED → RESOLVED

Closed: 4 years ago → 4 years ago

status-firefox85: affected → fixed

Resolution: --- → FIXED

Tom Tung [:tt, :ttung]

Updated

•

4 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1682100

Simon Giesecke [:sg] [he/him]

Updated

•

4 years ago

Regressions: 1682100

See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=1682100 →

You need to log in before you can comment on or make changes to this bug.