Closed Bug 1680548 Opened 4 years ago Closed 4 years ago

Cache max length in TextControlState::SelectionProperties when calling SetValue

Categories

(Core :: DOM: Selection, enhancement, P3)

Product:
Core
Component:
DOM: Selection
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(1 file)

Bug 1680548 - Cache the max length in TextControlState::SelectionProperties r=masayuki
(deleted), text/x-phabricator-request
Details

A followup after https://phabricator.services.mozilla.com/D98185. Sounds worth doing as I have more plan to introduce changes there.

GetValue() is not a cheap operation, and this allows to skip it in SetSelectionRange.

Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/651187869807 Cache the max length in TextControlState::SelectionProperties r=masayuki
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26763 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b9fa2c214287 Cache the max length in TextControlState::SelectionProperties r=masayuki
Upstream PR was closed without merging
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0094ef4f5dd Cache the max length in TextControlState::SelectionProperties r=masayuki

https://hg.mozilla.org/mozilla-central/rev/f0094ef4f5dd

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Flags: needinfo?(krosylight)
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: