Make the CSS tokenizer pass the whole parser state, not just the source location, to the parser
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
|
(deleted),
text/x-github-pull-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/plain
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
The changes should be trivial.
The third_party changes are up for review in
https://github.com/servo/rust-cssparser/pull/277 (and of course I'll
land with a bump to 0.28 rather than the override after that gets r+'d).
The basic idea is that with this we have the actual start offset of the
rule, so we wouldn't include html comments or other invalid stuff we
discard during sanitization in bug 1680084. But that's a separate
change.
|
||
Comment 4•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer?job_id=323536942&repo=autoland&lineNumber=7803
Backout: https://hg.mozilla.org/integration/autoland/rev/c41f1530160d756a8223706179bd408d8e77b0ac
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 6•4 years ago
|
||
Comment on attachment 9191135 [details]
Bug 1680558 - Update cssparser to get ParserState in rule parser. r=#style
Beta/Release Uplift Approval Request
- User impact if declined:
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple change to cssparser to provide more state to its consumers.
- String changes made/needed: none
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: blocks bug 1680084
- User impact if declined: none
- Fix Landed on Version: 85
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): see above
- String or UUID changes made by this patch: none
|
|
Assignee | |
Comment 7•4 years ago
|
||
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
|
||
Comment 9•4 years ago
|
||
Comment on attachment 9191135 [details]
Bug 1680558 - Update cssparser to get ParserState in rule parser. r=#style
Approved for 84.0rc1 and 78.6esr.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 10•4 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 11•4 years ago
|
||
| bugherder uplift | ||
Description
•