[1538348 subtask 5] Cancelling downloads on certain HTTP status codes - add support to WebExecutor
Categories
(GeckoView :: Extensions, task, P1)
Tracking
(firefox85 fixed)
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: owlish, Assigned: owlish)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:m85])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is needed to implement allowHttpErrors functionality [1] in Web Extension downloads API.
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/downloads/download
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Upon some discussion, Agi and I came to conclusion there is no need for this flag in Web Executor, since the status code can be checked in JVM and the download doesn't need to be completed for that. Having the flag would then seem like a duplicate of the existing API. In embedding code that plugs in multiple download managers (built in Android DownloadManager, for example) the check for the http status would still need to be done (either conditionally - depending on which download manager is being used - or not).
The flag is passed as part of the Downloadrequest, so the embedding code gets it and can implement the functionality using the existing Web Executor (or Android DownloadManager or some other tool) APIs.
So the initial patch for this bug https://phabricator.services.mozilla.com/D98698 was abandoned and instead we are removing dead (or rather still-born) code.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•