Closed
Bug 1680780
Opened 4 years ago
Closed 2 years ago
Set correct `attached` status for Targets in TargetInfo
Categories
(Remote Protocol :: CDP, enhancement, P3)
Remote Protocol
CDP
Tracking
(firefox111 fixed)
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: whimboo, Assigned: canadahonk)
References
Details
(Whiteboard: [puppeteer-beta2-mvp])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
As noticed on bug 1680740 we do not have a proper way to determine which targets are currently attached. And as such miss this property in the TargetInfo dictionary of various commands and events.
Maybe we could check if the Tab has a valid TabSession?
Lets wait for bug 1680740 so we can better test it.
|
Reporter | |
Updated•4 years ago
|
Whiteboard: [puppeteer-beta2-mvp]
|
|
Reporter | |
Updated•4 years ago
|
Priority: P2 → P3
|
||
Updated•4 years ago
|
Component: CDP: Target → CDP
|
|
Reporter | |
Updated•3 years ago
|
Assignee: hskupin → nobody
Status: ASSIGNED → NEW
|
Assignee | |
Comment 1•2 years ago
|
||
Now checks if the target is attached by going through all sessions in
the CDP connection. Also updated tests to expect new fixed behavior.
|
||
Updated•2 years ago
|
Assignee: nobody → oj
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5b90b00d80e
[cdp] Set correct attached status in TargetInfo r=webdriver-reviewers,whimboo
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•