Double-click in address bar select incorrect word
Categories
(Core :: DOM: Selection, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox83 | --- | unaffected |
firefox84 | --- | unaffected |
firefox85 | --- | fixed |
People
(Reporter: gwarser, Assigned: saschanaz)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0
Steps to reproduce:
- build 20201205093858
- load long URL, can be https://www.reddit.com/r/firefox/comments/k75oaz/weekly_discussion_for_nightly_builds_for_20201205/
- restore Firefox to "windowed" state, put some buttons or search bar in toolbar to make URL in address bar fade-out on right side
- double-click on
www
in address bar in attempt to select
Actual results:
- some word right of the
www
is selected
Expected results:
www
should be selected
Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6359a76a8df76826dd3b18bfcb6c1a0e011e2cd7&tochange=8ae44c88ef965eaedf349b1bb7f3f247740f0263
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
input.select();
input.setSelectionRange(0, Number.MAX_SAFE_INTEGER);
setSelectionRange()
(and also other setters) has a Gecko-only behavior that autoscrolls to the end of the text, and now select()
also behaves same.
Assignee | ||
Comment 2•4 years ago
|
||
This is intended to be a hotfix for the URL bar regression. Ideally there should be a spec or this behavior should be removed completely.
Previously select() scrolled back to the start position before the regression, but this fix does not restore that behavior.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Backed out for failure on browser_blockingCookies.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/62495078fd2913be744a941058c4c5ae04e6bedb
Failure log: https://treeherder.mozilla.org/logviewer?job_id=323897907&repo=autoland&lineNumber=4387
Assignee | ||
Comment 7•4 years ago
|
||
It doesn't seems to be related to my patch, but a reverting commit does fix it (only on Linux and macOS). Hmm. 🤔
Comment 9•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Description
•