Closed Bug 1680951 Opened 4 years ago Closed 4 years ago

Double-click in address bar select incorrect word

Categories

(Core :: DOM: Selection, defect, P2)

Firefox 85
defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: gwarser, Assigned: saschanaz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Actual results:

  • some word right of the www is selected

Expected results:

  • www should be selected

Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6359a76a8df76826dd3b18bfcb6c1a0e011e2cd7&tochange=8ae44c88ef965eaedf349b1bb7f3f247740f0263

Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → DOM: Selection
Product: Firefox → Core
Flags: needinfo?(krosylight)
input.select();
input.setSelectionRange(0, Number.MAX_SAFE_INTEGER);

setSelectionRange() (and also other setters) has a Gecko-only behavior that autoscrolls to the end of the text, and now select() also behaves same.

Assignee: nobody → krosylight
Flags: needinfo?(krosylight)

This is intended to be a hotfix for the URL bar regression. Ideally there should be a spec or this behavior should be removed completely.

Previously select() scrolled back to the start position before the regression, but this fix does not restore that behavior.

Severity: -- → S3
Priority: -- → P2
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29bbd5887d66 Do not scroll when calling select() r=masayuki
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26794 for changes under testing/web-platform/tests
Upstream PR was closed without merging

It doesn't seems to be related to my patch, but a reverting commit does fix it (only on Linux and macOS). Hmm. 🤔

Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8ef444371de Do not scroll when calling select() r=masayuki
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Upstream PR merged by moz-wptsync-bot
Flags: in-testsuite+
Regressed by: 1679461
Regressions: 1685153
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: