Closed
Bug 1681011
Opened 4 years ago
Closed 4 years ago
Make CompilationStencil.moduleMetadata optional
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
StencilModuleMetadata contains multiple vectors, and ctor/dtor cost of them are not negligible.
since most scripts are not module at this point, we can reduce the cost by making CompilationStencil.moduleMetadata field Maybe.
Once module usage grows, we can apply the same optimization as other fields (replacing Vector with Span).
|
Assignee | |
Comment 1•4 years ago
|
||
To suppress ctor/dtor cost of Vectors inside StencilModuleMetadata,
Make CompilationStencil.moduleMetadata Maybe and emplace only when compiling/
decoding module.
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/2bab943a5208
Make CompilationStencil.moduleMetadata field optional. r=nbp
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•