Closed
Bug 1681098
Opened 4 years ago
Closed 4 years ago
Resizing a window with lockaspectratio via resizeTo or resizeBy should update aspect ratio
Categories
(Core :: Widget: Win32, defect, P5)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
86 Branch
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: mconley, Assigned: masterwayz, Mentored)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Open a private browsing window (this is to increase the likelihood of viewing an advertisement on YouTube)
- In that private window, visit https://www.youtube.com/watch?v=sb3FJdRk-tI
- Hopefully you get an advertisement. If not, go back to 1.
- While the advertisement is playing, put it into Picture-in-Picture mode. If the toggle doesn't appear for you (for example, if the ad is less than 45 seconds long), double-right click on the ad and use the context menu to put it into Picture-in-Picture
- Once the ad is open in Picture-in-Picture mode, note the aspect ratio of the player window.
- Click on "Skip Ad" or wait for the advertisement(s) to finish, and the music video to begin.
- Note that the player window resizes itself to a new aspect ratio.
- Attempt to manually resize the window.
ER:
The player window should maintain the new aspect ratio.
AR:
The player window snaps back to the original aspect ratio.
Reporter | ||
Comment 1•4 years ago
|
||
The easiest way to do this would probably be to check if we're locking the aspect ratio here: https://searchfox.org/mozilla-central/rev/1843375acbbca68127713e402be222350ac99301/widget/windows/nsWindow.cpp#2036
by checking if mAspectRatio != 0.0
, and if so, to call LockAspectRatio(false)
, and then after setting the bounds, re-locking with LockAspectRatio(true)
.
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → michelle
Mentor: mconley
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3574370c361
Update the aspect ratio when a PiP video gets resized r=mconley
Comment 4•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•