Closed Bug 1681406 Opened 4 years ago Closed 4 years ago

error: use of undeclared identifier 'CLOCK_REALTIME' when building on OSX

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox83 unaffected, firefox84 unaffected, firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: mccr8, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I'm unable to build Firefox locally on OSX. It looks like the code in question was added by bug 1678174.

Flags: needinfo?(jld)

Reverting the patch seems to fix it ( https://hg.mozilla.org/integration/autoland/rev/491fa5186e7f )

Type: task → defect

POSIX is pretty unambiguous here:

All implementations shall support a clock_id of CLOCK_REALTIME as defined in <time.h>.

But Apple's headers are weird (abridged for clarity):

#define __CLOCK_AVAILABILITY __OSX_AVAILABLE(10.12) …
…
typedef enum {
_CLOCK_REALTIME __CLOCK_AVAILABILITY = 0,
#define CLOCK_REALTIME _CLOCK_REALTIME
…

Maybe it doesn't include POSIX clock support if it thinks the target OS might be older than 10.12?

Flags: needinfo?(jld)

From some discussion on Element in developers with Glandium, it appears the problem is that I'm using the 10.11 SDK.

Assignee: nobody → mh+mozilla
Component: Security: Process Sandboxing → General
Product: Core → Firefox Build System

Bug 1680152 updated automation to use the 10.12 SDK, and shortly after,
bug 1678174 introduced a change that broke the build with the 10.11 SDK.
Considering we haven't actually supported running on macos 10.11 and
earlier since Firefox 79, and that still supporting building with the
10.11 SDK would mean adding and maintaining code that, in practice,
would never be used by users, I think it is fair at this point that we
just drop support for the 10.11 SDK entirely.

Depends on: 1680152

Could you send an announcement to mozilla.dev.platform about this? We've generally recommended everyone build with the 10.11 SDK, so lots of people will need to change their setup.

Flags: needinfo?(mh+mozilla)

(In reply to Markus Stange [:mstange] from comment #5)

Could you send an announcement to mozilla.dev.platform about this? We've generally recommended everyone build with the 10.11 SDK, so lots of people will need to change their setup.

Done already.

(In reply to Markus Stange [:mstange] from comment #6)

Furthermore, the following pieces of documentation need to be updated:

Can you paste that in bug 1680441?

Flags: needinfo?(mh+mozilla)

Thanks! Done.

Set release status flags based on info from the regressing bug 1678174

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/3c639828681a Require 10.12 SDK for the build. r=firefox-build-system-reviewers,dmajor
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Blocks: 1697343
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: