Closed Bug 1681623 Opened 4 years ago Closed 4 years ago

Simplify pages-per-sheet data & logic to only store a single track count (either the row or column count), since the other one is implicit

Categories

(Core :: Printing: Output, task)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I'm spinning this bug off as a way to land a r+'d refactoring helper patch that I had initially posted as "part 1" on bug 1669905, because bug 1669905 still has more work to be done.

I'd like to land the refactoring patch now, even if bug 1669905 doesn't happen to make it in for this cycle, to reduce potential uplift/rebasing burden down the line. Hence, spinning this off to its own bug.

This patch doesn't change behavior. It's just a simplification of the data
that we track for our different pages-per-sheet mode (with some minor
refactoring of the logic involved).

This is a necessary step towards implementing support for 2 and 6
pages-per-sheet (which are referenced in comments included in this patch,
and which will be implemented separately in bug 1669905)

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ac4de9342fc Simplify pages-per-sheet data & logic to only store a single track count (either the row or column count), since the other one is implicit. r=TYLin

I'd like to land the refactoring patch now, even if bug 1669905 doesn't happen to make it in for this cycle, to reduce potential uplift/rebasing burden down the line. Hence, spinning this off to its own bug.

Sounds good to me. Thanks!

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: