This was created on request to: see bug 1666739 comment 33 and comment 31 for more details. This issue was created in order to address the remaining problem from bug 1666739.

Affected versions

• 85.0a1(20201209213504)
• 84.0 (20201207203640)
• 83.0 (20201112153044)

Affected platforms

• Windows 10x64
• Ubuntu 18.04
• macOS 11

Steps to reproduce

1. Open Firefox with a new profile and go to a random Youtube video.
2. Make sure that an ad is playing with at least 45 seconds.
3. Resize the browser horizontally to make it smaller.
4. Click on the Skip ads button over the PiP button.

Expected result

• Ad is skipped.

Actual result

• The PiP player is opened and the ad is not skipped.

Notes

• Attached a screen recording.
• The issue may be intermittent, because sometimes when clicking the button the ad is skipped.

Suggested Severity: S3

Mike, do you have some kind of intuition of what is happening here after the fix from bug 1666739? Is the issue that (in the screencast, at least), the button doesn't show while the skip ads button is hovered, but then shows when moving the mouse below the skip ads button, and doesn't re-hide when moving the mouse back over the skip ads button? Alexandru, can you reproduce without those mouse movements or am I misreading the video?

(In reply to :Gijs (he/him) from comment #1)

Mike, do you have some kind of intuition of what is happening here after the fix from bug 1666739? Is the issue that (in the screencast, at least), the button doesn't show while the skip ads button is hovered, but then shows when moving the mouse below the skip ads button, and doesn't re-hide when moving the mouse back over the skip ads button? Alexandru, can you reproduce without those mouse movements or am I misreading the video?

After further looking into this I observed that the PiP button doesn't show up when hovering the timer that shows before the skip ad button. I made a screen recording here for a better understanding while the timer is displayed: link.

But if the skip ad button is displayed the PiP button is displayed as well even if I hover only the skip ad button (see attached screen recording: link). In the first video added that was misleading indeed because the timer and the skip ad button were displayed as well hiding the PiP button and mouse movements where necessary to show it again.
The issue is intermittent sometimes because after some interaction with the video (Play/Pause) the skip ad button is pressed instead of the PiP one. If more information is needed please let me know. Thank you!

It looks like the "Skip Ad" overlay has an opacity of 0.7, which is lower than our visibility check threshold, meaning we consider it "transparent" and let the user click-through to PiP.

Adjusting the threshold to 0.7 seems to fix the issue. I'll post a patch.

Hi atrif,

I've done some preliminary testing, and this patch seems to address it. When the try build is done, would you mind running this on your Windows machine:

./mach mozregression --repo try --launch c926949a96996efd294c1dc1aa8dbf7db49a9df2

To give my patch a shot to see if it fixes things on your end, too?

(In reply to Mike Conley (:mconley) (:⚙️) from comment #5)

Hi atrif,

I've done some preliminary testing, and this patch seems to address it. When the try build is done, would you mind running this on your Windows machine:

./mach mozregression --repo try --launch c926949a96996efd294c1dc1aa8dbf7db49a9df2

To give my patch a shot to see if it fixes things on your end, too?

I can confirm that the PiP player is no longer enabled while clicking the Skip Ad button when PiP button is smaller using the provided build on Windows 10x64. Thank you!

https://hg.mozilla.org/mozilla-central/rev/2c36387fdef8

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

The issue is verified fixed with Firefox 86.0a1 (20210104090857) on Windows 10x64, macOS 10.12 and Ubuntu 20. When clicking on the Skip Ad button while the PiP player is displayed with a small browser window, the ad is skipped as expected.