Closed Bug 1681811 Opened 4 years ago Closed 4 years ago

Update mp4parse-rust to 94fd2f1

Categories

(Core :: Audio/Video: Playback, task, P1)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(1 file)

With the update, we are able to read the alpha data from Mp4parseAvifParser for avif images

Import the improvements made in mp4parse-rust repo. The changes would
save some redundant copy when calling avif related APIs and provide the
ability to get the alpha data of the parsed avif image.

Blocks: 1654462
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8c087a36965 Update mp4parse-rust to 94fd2f1 r=jbauman

Backed out for causing failures on test_case_mp4

backout: https://hg.mozilla.org/integration/autoland/rev/24d6cfe44297fcd94bfd6e87b8ebb856cc66b7c3

push: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cwebrender%2Copt%2Ctest-macosx1014-64-qr%2Fopt-gtest-1proc%2Cgtest&revision=a8c087a36965c2e235587519539621790d30b5cc&selectedTaskRun=LNU_1BJ0SraNzcYdBbD6WQ.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=324286421&repo=autoland&lineNumber=29156

[task 2020-12-11T20:50:36.426Z] 20:50:36 INFO - TEST-START | MP4Metadata.test_case_mp4
[task 2020-12-11T20:50:36.426Z] 20:50:36 WARNING - TEST-UNEXPECTED-FAIL | MP4Metadata.test_case_mp4 | Expected equality of these values:
[task 2020-12-11T20:50:36.426Z] 20:50:36 INFO - tests[test].mNumberAudioTracks
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - Which is: 2
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - metadata.GetNumberTracks(TrackInfo::kAudioTrack).Ref()
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - Which is: 1
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - test_case_1185230.mp4 @ /builds/worker/checkouts/gecko/dom/media/gtest/mp4_demuxer/TestParser.cpp:280
[task 2020-12-11T20:50:36.427Z] 20:50:36 WARNING - TEST-UNEXPECTED-FAIL | MP4Metadata.test_case_mp4 | Expected equality of these values:
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - tests[test].mNumberVideoTracks
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - Which is: 2
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - metadata.GetNumberTracks(TrackInfo::kVideoTrack).Ref()
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - Which is: 1
[task 2020-12-11T20:50:36.427Z] 20:50:36 INFO - test_case_1185230.mp4 @ /builds/worker/checkouts/gecko/dom/media/gtest/mp4_demuxer/TestParser.cpp:283
[task 2020-12-11T20:50:36.428Z] 20:50:36 WARNING - TEST-UNEXPECTED-FAIL | MP4Metadata.test_case_mp4 | Expected equality of these values:
[task 2020-12-11T20:50:36.428Z] 20:50:36 INFO - tests[test].mAudioDuration
[task 2020-12-11T20:50:36.428Z] 20:50:36 INFO - Which is: 5
[task 2020-12-11T20:50:36.428Z] 20:50:36 INFO - audioInfo->mDuration.ToMicroseconds()
[task 2020-12-11T20:50:36.428Z] 20:50:36 INFO - Which is: 477460
[task 2020-12-11T20:50:36.428Z] 20:50:36 INFO - test_case_1185230.mp4 @ /builds/worker/checkouts/gecko/dom/media/gtest/mp4_demuxer/TestParser.cpp:336

Flags: needinfo?(cchang)
Depends on: 1661583
Depends on: 1670341
No longer depends on: 1661583
Flags: needinfo?(cchang)
Attachment #9192479 - Attachment description: Bug 1681811 - Update mp4parse-rust to 94fd2f1 → Bug 1681811 - Update mp4parse-rust to 3d9efdc
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/106bbc2238f0 Update mp4parse-rust to 3d9efdc r=jbauman
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: