Closed Bug 1681849 Opened 4 years ago Closed 4 years ago

Convert rest of the members in ReflowInput to store in logical coordinates

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Similar to Bug 1675128, this bug tracks the work to convert rest of the members in ReflowInput to store in logical coordinates.
https://searchfox.org/mozilla-central/rev/4415bec7a49c50a338167d9c8934527b9cae59d0/layout/generic/ReflowInput.h#452-493,499-506

I put the private member section at the end of ReflowInput's
declarations. In later patches, other members are going to live there
when they're converted to logical coordinates.

Remove unused AvailableWidth() and AvailableHeight() that return
writable-references.

I didn't port the comment section verbatim, but revise them according to
the best of my knowledge.

We can use them to implement SetComputedWidth() and SetComputedHeight()
rather than the other way around.

The logic involving whether to call InitResizeFlags() for viewport frame
can be simplified. That is, we don't want to call InitResizeFlags() for
viewport frame in SetComputedISize().

Remove unused ComputedWidth() and ComputedHeight() that return
writable-references.

Delete the comment describing that replaced frames should use their
intrinsic size if they have NS_UNCONSTRAINEDSIZE in mComputedWidth and
mComputedHeight, because we always have a definite size computed by
ComputeSizeWithIntrinsicDimensions().

Remove unused ComputedMinWidth(), ComputedMaxWidth(),
ComputedMinHeight(), and ComputedMaxHeight() that return
writable-references.

s/aContainingBlockSize/aCBSize/ for ComputeMinMaxValues() because that's
the parameter name used in definition.

Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bab2af0beed8 Part 1 - Change available block and inline size to store in LogicalSize. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/f875e1fd1c37 Part 2 - Reimplement SetComputedISize() and SetComputedBSize(). r=emilio https://hg.mozilla.org/integration/autoland/rev/27eae27154d2 Part 3 - Change the computed inline-size and block-size to store in LogicalSize. r=emilio https://hg.mozilla.org/integration/autoland/rev/80ed365889fc Part 4 - Change computed min-size and max-size to store in LogicalSize. r=emilio https://hg.mozilla.org/integration/autoland/rev/4e0ba157c016 Part 5 - Revise comments in ReflowInput.h. r=emilio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: