Identify top-level browsers using browserId instead of browsingContext's id
Categories
(Remote Protocol :: Marionette, task, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
(Whiteboard: [not-a-fission-bug])
Internally, marionette keeps track of currently open browsers. For instance, in driver.js there is the _browserIds
map: https://searchfox.org/mozilla-central/search?path=&q=_browserIds which maps a browser permanentKey to the browsing context id.
However the browsing context id is not a stable id. When navigating across processes, browsing contexts will be swapped and the id will change. Instead for top level browser elements, we could use the browsingContext.browserId.
Since this id "leaks" to several helpers (in production code and test code), changing the logic will require to update all of them at once. See discussion at https://phabricator.services.mozilla.com/D98779#inline-559687
Comment 1•4 years ago
|
||
Henrik, is this bug related to Fission? Does it need to block shipping Fission MVP?
This bug blocks "Refactor registration of browsers" bug 1676671, which has a [marionette-fission-mvp]
whiteboard tag.
Comment 2•4 years ago
|
||
It doesn't block our Fission implementation per se given that it was already a problem before. Also it doesn't block the browser registration, but depends on it. So no, it doesn't block Fission MVP.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
To reduce the risks for regressions lets do it when all the framescript code has been removed.
Comment 5•4 years ago
|
||
Actually this is a dupe of bug 1680479.
Updated•2 years ago
|
Description
•