Switch WindowsPreviewPerTab from drawWindow to drawSnapshot for Fission
Categories
(Core :: Widget: Win32, task)
Tracking
()
Fission Milestone | M7 |
People
(Reporter: smacleod, Unassigned)
References
(Blocks 1 open bug)
Details
CanvasRenderingContext2D.drawWindow()
is synchronous and won't work with fission, so WindowsPreviewPerTab.jsm
[1] must be updated to use the asynchronous drawSnapshot
[2]
Comment 2•4 years ago
|
||
I am vaguely under the impression that WindowsPreviewPerTab.jsm
is only used in the parent process, where IIRC drawWindow
may still work correctly (though please correct me if I'm wrong on that :mattwoodrow). We may not need to make changes here?
Comment 3•4 years ago
|
||
If we're calling from the parent process, and only trying to capture content from the parent process (which it appears that we are, from the code linked in comment 0), then this will continue to work fine.
Comment 4•4 years ago
|
||
Does comment 3 mean we can close this? Can we look at all WindowsPreviewPerTab.jsm usage to see if it's all from the parent?
Comment 5•4 years ago
|
||
Gijs, are you the right person to confirm that this will only run in the parent process? Thanks!
Comment 6•4 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #5)
Gijs, are you the right person to confirm that this will only run in the parent process? Thanks!
Yes, it will only run in the parent - https://searchfox.org/mozilla-central/search?q=WindowsPreviewPerTab shows it's only loaded from browser.js, which only runs in the parent process.
Updated•4 years ago
|
Description
•