Closed Bug 1682021 Opened 4 years ago Closed 4 years ago

Switch eye-dropper's getWindowAsImageData from drawWindow to drawSnapshot for Fission

Categories

(DevTools :: Inspector, task)

task

Tracking

(Fission Milestone:Future)

RESOLVED DUPLICATE of bug 1568831
Fission Milestone Future

People

(Reporter: smacleod, Unassigned)

References

(Blocks 2 open bugs)

Details

CanvasRenderingContext2D.drawWindow() is synchronous and won't work with fission, so eye-dropper.js[1] must be updated to use the asynchronous drawSnapshot[2]

  1. https://searchfox.org/mozilla-central/source/devtools/server/actors/highlighters/eye-dropper.js#539
  2. https://searchfox.org/mozilla-central/rev/9b282b34b5/dom/chrome-webidl/WindowGlobalActors.webidl#81-98

Tracking dt-fission bugs for Fission MVP.

Fission Milestone: --- → MVP
Component: Inspector: Highlighters → Inspector

Sending this bug to dt-fission triage. Should we fix this bug for Fission MVP? We were tracking this bug for Fission MVP milestone, but it didn't have a dt-fission whiteboard tags.

Also, if we want to fix this bug before shipping Fission, we should fix it in our Fission M8 milestone. (The Fission MVP milestone is now intended for tracking meta bugs and last minute fixes.)

Fission Milestone: MVP → ?
Whiteboard: dt-fission-m3-triage

The eye dropper is already making use of drawSnapshot since Bug 1568831.
We only keep the call to drawWindow as a safety net in case there was an issue when calling drawSnapshot.

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

The eye dropper is already making use of drawSnapshot since Bug 1568831.
We only keep the call to drawWindow as a safety net in case there was an issue when calling drawSnapshot.

In that case, can we resolve this bug as WONTFIX?

If someone eventually removes the drawWindow API itself (bug 1682545), they will remove the eye dropper's use of drawWindow then.

Blocks: 1682545
Fission Milestone: ? → Future
Flags: needinfo?(nchevobbe)

Sure, I'll dupe this one

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(nchevobbe)
Resolution: --- → DUPLICATE
Whiteboard: dt-fission-m3-triage
You need to log in before you can comment on or make changes to this bug.