Closed
Bug 1682028
Opened 4 years ago
Closed 4 years ago
Switch PageThumbUtils.jsm createSnapshotThumbnail from drawWindow to drawSnapshot for Fission
Categories
(Firefox :: New Tab Page, task, P3)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: smacleod, Assigned: thecount)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
CanvasRenderingContext2D.drawWindow() is synchronous and won't work with fission, so PageThumbUtils.jsm[1] must be updated to use the asynchronous drawSnapshot[2]
|
Assignee | |
Updated•4 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(sdowne)
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → sdowne
Flags: needinfo?(sdowne)
|
|
Assignee | |
Comment 3•4 years ago
|
||
I found the best way to test this is with bookmarks.
- Open about:config
- Click the bookmark button.
Expected: Should see a thumbnail in the bookmark edit menu, and it should make the same thumbnail that you see on nightly.
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/7ee85cbc538d
Switch PageThumbUtils.jsm createSnapshotThumbnail from drawWindow to drawSnapshot r=smacleod
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•