Closed
Bug 1682029
Opened 4 years ago
Closed 4 years ago
Remove unused screenshotToDataUrl in devtools/server/actors/device.js
Categories
(DevTools :: General, task, P3)
DevTools
General
Tracking
(firefox86 fixed)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: smacleod, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
While auditing for Bug 1678480 I came across a call in device.js which appears to be dead code.
I believe this code may be removed along with the reference in the spec.
|
Assignee | |
Comment 1•4 years ago
|
||
FWIW try seems ok with the removal: https://treeherder.mozilla.org/jobs?repo=try&revision=c050fee281e0e4899c89afd2438bb2c1221fc471
|
||
Comment 2•4 years ago
|
||
Thanks for filing the report Steven!
Are you interested in providing a patch for this?
Honza
|
|
Assignee | |
Comment 3•4 years ago
|
||
I had patches around for this, let's upload and land this.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(smacleod)
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09f21ccdc3d0 [devtools] Remove unused screenshotToDataUrl in devtools/server/actors/device.js r=devtools-backward-compat-reviewers,nchevobbe
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•