Closed Bug 1682153 Opened 4 years ago Closed 4 years ago

Script resources blocked by CSP are not displayed in the Network Monitor with Fission Enabled

Categories

(Core :: Networking, defect, P2)

78 Branch
defect

Tracking

()

RESOLVED FIXED
89 Branch
Fission Milestone M7a
Tracking Status
firefox89 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp [necko-triaged])

Attachments

(1 file)

STR

  1. Go to https://indigo-dandelion-particle.glitch.me/
  2. Open the Network monitor
  3. Make sure "Disable Cache" is checked
  4. Make sure all fission prefs are on , especially devtools.testing.enableServerWatcherSupport
  5. Reload the page

Actual results:
Cannot see the script request which is blocked by CSP in the Network Monitor.

Expected results:
Script request blocked by CSP should be displayed in the network monitor.

Note:
Setting the devtools.testing.enableServerWatcherSupport to false, reloading the browser and then the page causes the script to show up.

Also this causes browser_net_block-csp.js test to fail, this would be disabled for fission until this is fixed.

Whiteboard: dt-fission-m3-mvp

Hello Valentin,
We see this issue with fission enabled, scripts are no longer visible.
It seems closely related to Bug 1638259, where a solution is suggested.
Do you think that's a fair assumption, I'm look to investigate and try that.

Flags: needinfo?(valentin.gosu)

Hi Hubert,

Yes, I suspect it's the same issue.
Christoph could probably confirm if that's the case.

Flags: needinfo?(valentin.gosu)

Tracking dt-fission-m3-mvp bugs for Fission MVP.

Fission Milestone: --- → MVP

Thanks Valentin!

Hello Christoph,
Would you be able to confirm that this issue is closely related to Bug 1638259.

Flags: needinfo?(ckerschb)

Moving to the networking component

Component: Netmonitor → Networking
Product: DevTools → Core

(In reply to Hubert Boma Manilla (:bomsy) from comment #4)

Would you be able to confirm that this issue is closely related to Bug 1678795.

Yes, this bug is very similar to (in fact the same problem as) Bug 1678795. In particular, see Comment 22 in Bug 1678795.

Very likely we have that problem for more content types, not only style and script - basically whenever we perform a security check where we do not have a created an nsIChannel yet. In particular we can search for SEC_ONLY_FOR_EXPLICIT_CONTENTSEC_CHECK which provides all the problematic callsites.

Flags: needinfo?(ckerschb)
Depends on: 1678795
Whiteboard: dt-fission-m3-mvp → dt-fission-m3-mvp [necko-triaged]

I think there was a copy and paste error starting in comment 4 and that we're actually talking about bug 1638259 because :ckerschb's comment in comment 6 linking to a comment was linking to https://bugzilla.mozilla.org/show_bug.cgi?id=1638259#c22. :ckerschb can you confirm this?

Depends on: 1638259
No longer depends on: 1678795
Flags: needinfo?(ckerschb)

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #7)

I think there was a copy and paste error starting in comment 4 and that we're actually talking about bug 1638259 because :ckerschb's comment in comment 6 linking to a comment was linking to https://bugzilla.mozilla.org/show_bug.cgi?id=1638259#c22. :ckerschb can you confirm this?

Yes, thanks for fixing that up and sorry about the confusion, it's comment 22 in Bug 1638259 I was talking about.

Flags: needinfo?(ckerschb)

Thanks for the catch Andrew, I made the original mistake in comment 4.
Thanks

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Fission Milestone: MVP → M7
Depends on: 1689644

Tracking dt-fission-m3-mvp test and infrastructure bugs for Fission M8 (blocking Release experiment).

Fission Milestone: M7 → M8

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Fission Milestone: M8 → MVP

Depends on D103665

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3eb17e639591
[devtools] Enable CSP script blocking test r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Fission Milestone: MVP → M7a
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: