Closed Bug 1682931 Opened 4 years ago Closed 4 years ago

JavaStackTrace shows different key names between details and metadata tabs

Categories

(Socorro :: Webapp, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

Attachments

(1 file)

Crash reports from android can have a JavaStackTrace annotation. The value is a single string which has the exception type, message, and a stack.

The exception message can have PII in it, so the processor sanitizes it and creates two fields in the processed crash: java_stack_trace and java_stack_trace_raw

https://github.com/mozilla-services/socorro/blob/f70a627fee0d898202158352e25c73099ce02ee1/socorro/processor/rules/mozilla.py#L261-L280

If you don't have protected data access, then on the Details tab, you see the "JavaStackTrace (redacted)" key with the java_stack_trace value. It doesn't show up at all on the Metadata tab.

If you do have protected data access, then on the Details tab, you see JavaStackTrace (Raw) key with the java_stack_trace_raw value and on the Metadata tab, you see JavaStackTrace with the java_stack_trace_raw value.

If you have protected data access, this is confusing because you're seeing both the raw value in the Details tab and the sanitized value in the Metadata tab and they have the same value which makes it seem like Crash Stats is not sanitizing the value correctly.

We should make this clearer.

The keys on the Metadata tab are from the raw crash. The view makes sure that the viewer can only view the keys they are allowed to see. That's set in super_search_fields.py.

Two things:

  1. I think we can add a raw_crash.JavaStackTrace item to super_search_fields.py with the right description and set it to not index the field. So then it'll show up with the correct description.
  2. It's weird that it doesn't show the protected data statements for protected data fields. It should do that.
  3. The JavaStackTrace (the raw one) should also be labeled as protected data on the Details page.

Making this a P2 to work on because we really want protected data to be clearly labeled on the site. Grabbing it to work on next year.

Assignee: nobody → willkg
Status: NEW → ASSIGNED
Priority: -- → P2

I was thinking about this today and had a different idea.

First off, I kind of hate the current Metadata tab. I think it's misnamed and it's not clear what that tab holds or where that data comes from. It's not clear that that tab holds the original unprocessed crash annotation values (plus what the collector adds--but that's a bug for a different day).

So I think I want to adjust the plan to this:

  1. rename the tab from "Metadata" to "Crash Annotations"
  2. add some text at the top that has a link to the CrashAnnotations.yaml file in moz-central
  3. split the annotations into "public" and "protected" and only show the latter if the user has access to protected data for that crash report
  4. add the "Protected data: Protected data policy." label to the protected data section
  5. adjust the java_stack_trace (the raw one) description to state it's protected data

Working on that today.

I pushed this out today in bug #1688681. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: