Closed
Bug 1682945
Opened 4 years ago
Closed 4 years ago
Replace idl nsISimpleEnumerator usage with Array<T> in mailnews/search/
Categories
(MailNews Core :: General, task)
MailNews Core
General
Tracking
(thunderbird_esr78 wontfix)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | wontfix |
People
(Reporter: benc, Assigned: benc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Replacing nsISimpleEnumerator with Array<> (where sensible!)
This covers:
mailnews/search/public/nsIMsgFilterService.idl
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → benc
|
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9197259 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9197259 [details] [diff] [review]
1682945-remove-nsISimpleEnumerator-in-nsIMsgFilterService-1.patch
Review of attachment 9197259 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
::: mailnews/search/public/nsIMsgFilterService.idl
@@ +53,5 @@
>
> /**
> * get the list of custom actions
> *
> * @return enumerator of nsIMsgFilterCustomAction objects
an array of
@@ +76,5 @@
>
> /**
> * get the list of custom search terms
> *
> * @return enumerator of nsIMsgSearchCustomTerm objects
an array of
Attachment #9197259 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f815431dbee5
Remove nsISimpleEnumerator use in nsIMsgFilterService. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•4 years ago
|
||
Noticed after the push, looks like you have the wrong email in your settings. Please fix.
|
|
Assignee | |
Comment 5•4 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #4)
Noticed after the push, looks like you have the wrong email in your settings. Please fix.
Doh. Thanks for spotting that - fixed now!
You need to log in
before you can comment on or make changes to this bug.
Description
•